[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 05/10] monitor: Drop query-qmp-schema 'gen': false hack
From: |
Eric Blake |
Subject: |
Re: [PATCH v6 05/10] monitor: Drop query-qmp-schema 'gen': false hack |
Date: |
Mon, 15 Mar 2021 11:10:21 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 |
On 3/12/21 9:32 AM, Markus Armbruster wrote:
> QMP commands return their response as a generated QAPI type, which the
> monitor core converts to JSON via QObject.
>
> query-qmp-schema's response is the generated introspection data. This
> is a QLitObject since commit 7d0f982bfb "qapi: generate a literal
> qobject for introspection", v2.12). Before, it was a string. Instead
> of converting QLitObject / string -> QObject -> QAPI type
> SchemaInfoList -> QObject -> JSON, we take a shortcut: the command is
> 'gen': false, so it can return the QObject instead of the QAPI type.
> Slightly simpler and more efficient.
>
> The next commit will filter the response for output policy, and this
> is easier in the SchemaInfoList representation. Drop the shortcut.
>
> This replaces the manual command registration by a generated one. The
> manual registration makes the commnd available before the machine is
command
> built by passing flag QCO_ALLOW_PRECONFIG. To keep it available
> there, we need need to add 'allow-preconfig': true to its definition
> in the schema.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> Reviewed-by: Eric Blake <eblake@redhat.com>
> ---
> qapi/introspect.json | 2 +-
> monitor/monitor-internal.h | 3 ---
> monitor/misc.c | 2 --
> monitor/qmp-cmds-control.c | 29 ++++++++++++++++------------
> storage-daemon/qemu-storage-daemon.c | 2 --
> 5 files changed, 18 insertions(+), 20 deletions(-)
>
R-b still stands.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
- [PATCH v6 04/10] qapi: Implement deprecated-output=hide for QMP event data, (continued)
- [PATCH v6 04/10] qapi: Implement deprecated-output=hide for QMP event data, Markus Armbruster, 2021/03/12
- [PATCH v6 08/10] qapi: Implement deprecated-input=reject for QMP commands, Markus Armbruster, 2021/03/12
- [PATCH v6 02/10] qapi: Implement deprecated-output=hide for QMP command results, Markus Armbruster, 2021/03/12
- [PATCH v6 07/10] test-util-sockets: Add stub for monitor_set_cur(), Markus Armbruster, 2021/03/12
- [PATCH v6 05/10] monitor: Drop query-qmp-schema 'gen': false hack, Markus Armbruster, 2021/03/12
- Re: [PATCH v6 05/10] monitor: Drop query-qmp-schema 'gen': false hack,
Eric Blake <=
- [PATCH v6 10/10] qapi: New -compat deprecated-input=crash, Markus Armbruster, 2021/03/12
- [PATCH v6 06/10] qapi: Implement deprecated-output=hide for QMP introspection, Markus Armbruster, 2021/03/12
- [PATCH v6 09/10] qapi: Implement deprecated-input=reject for QMP command arguments, Markus Armbruster, 2021/03/12
- [PATCH v6 03/10] qapi: Implement deprecated-output=hide for QMP events, Markus Armbruster, 2021/03/12
- Re: [PATCH v6 00/10] Configurable policy for handling deprecated interfaces, Markus Armbruster, 2021/03/18