[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 13/13] usb/storage: clear csw on reset
From: |
Gerd Hoffmann |
Subject: |
[PULL 13/13] usb/storage: clear csw on reset |
Date: |
Mon, 15 Mar 2021 19:02:40 +0100 |
Stale data in csw (specifically residue) can confuse the state machine
and allows the guest trigger an assert(). So clear csw on reset to
avoid this happening in case the guest resets the device in the middle
of a request.
Buglink: https://bugs.launchpad.net/qemu/+bug/1523811
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20210312094954.796799-1-kraxel@redhat.com>
---
hw/usb/dev-storage.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/usb/dev-storage.c b/hw/usb/dev-storage.c
index 7b587ad051ff..dca62d544fe9 100644
--- a/hw/usb/dev-storage.c
+++ b/hw/usb/dev-storage.c
@@ -313,6 +313,7 @@ void usb_msd_handle_reset(USBDevice *dev)
usb_msd_packet_complete(s);
}
+ memset(&s->csw, 0, sizeof(s->csw));
s->mode = USB_MSDM_CBW;
}
--
2.29.2
- [PULL 00/13] Usb 20210315 patches, Gerd Hoffmann, 2021/03/15
- [PULL 04/13] usb: Un-deprecate -usbdevice (except for -usbdevice audio which gets removed), Gerd Hoffmann, 2021/03/15
- [PULL 03/13] usb: remove '-usbdevice u2f-key', Gerd Hoffmann, 2021/03/15
- [PULL 07/13] hw/usb/hcd-uhci: Expose generic prototypes to local header, Gerd Hoffmann, 2021/03/15
- [PULL 13/13] usb/storage: clear csw on reset,
Gerd Hoffmann <=
- [PULL 01/13] hw/usb/bus: Remove the "full-path" property, Gerd Hoffmann, 2021/03/15
- [PULL 06/13] hw/southbridge: Add missing Kconfig dependency VT82C686 on USB_UHCI, Gerd Hoffmann, 2021/03/15
- [PULL 10/13] usb/storage: move usb-bot device to separate source file, Gerd Hoffmann, 2021/03/15
- [PULL 12/13] usb/storage: add kconfig symbols, Gerd Hoffmann, 2021/03/15
- [PULL 11/13] usb/storage move usb-storage device to separate source file, Gerd Hoffmann, 2021/03/15
- [PULL 08/13] hw/usb: Extract VT82C686 UHCI PCI function into a new unit, Gerd Hoffmann, 2021/03/15
- [PULL 05/13] usb: Document the missing -usbdevice options, Gerd Hoffmann, 2021/03/15
- [PULL 09/13] usb/storage: move declarations to usb/msd.h header, Gerd Hoffmann, 2021/03/15
- [PULL 02/13] usb: remove support for -usbdevice parameters, Gerd Hoffmann, 2021/03/15
- Re: [PULL 00/13] Usb 20210315 patches, Peter Maydell, 2021/03/16