[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[RFC v2 12/13] vhost: Check for device VRING_USED_F_NO_NOTIFY at shadow
From: |
Eugenio Pérez |
Subject: |
[RFC v2 12/13] vhost: Check for device VRING_USED_F_NO_NOTIFY at shadow virtqueue kick |
Date: |
Mon, 15 Mar 2021 20:48:41 +0100 |
Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
---
hw/virtio/vhost-shadow-virtqueue.c | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/hw/virtio/vhost-shadow-virtqueue.c
b/hw/virtio/vhost-shadow-virtqueue.c
index 68ed0f2740..7df98fc43f 100644
--- a/hw/virtio/vhost-shadow-virtqueue.c
+++ b/hw/virtio/vhost-shadow-virtqueue.c
@@ -145,6 +145,15 @@ static void vhost_shadow_vq_add(VhostShadowVirtqueue *svq,
svq->ring_id_maps[qemu_head] = elem;
}
+static void vhost_shadow_vq_kick(VhostShadowVirtqueue *svq)
+{
+ /* Make sure we are reading updated device flag */
+ smp_rmb();
+ if (!(svq->vring.used->flags & VRING_USED_F_NO_NOTIFY)) {
+ event_notifier_set(&svq->kick_notifier);
+ }
+}
+
/* Handle guest->device notifications */
static void vhost_handle_guest_kick(EventNotifier *n)
{
@@ -174,7 +183,7 @@ static void vhost_handle_guest_kick(EventNotifier *n)
}
vhost_shadow_vq_add(svq, elem);
- event_notifier_set(&svq->kick_notifier);
+ vhost_shadow_vq_kick(svq);
}
virtio_queue_set_notification(svq->vq, true);
--
2.27.0
- Re: [RFC v2 06/13] vhost: Route host->guest notification through shadow virtqueue, (continued)
- [RFC v2 12/13] vhost: Check for device VRING_USED_F_NO_NOTIFY at shadow virtqueue kick,
Eugenio Pérez <=
- [RFC v2 11/13] vhost: Shadow virtqueue buffers forwarding, Eugenio Pérez, 2021/03/15
- Re: [RFC v2 11/13] vhost: Shadow virtqueue buffers forwarding, Jason Wang, 2021/03/16
- Re: [RFC v2 11/13] vhost: Shadow virtqueue buffers forwarding, Eugenio Perez Martin, 2021/03/16
- Re: [RFC v2 11/13] vhost: Shadow virtqueue buffers forwarding, Jason Wang, 2021/03/16
- Re: [RFC v2 11/13] vhost: Shadow virtqueue buffers forwarding, Eugenio Perez Martin, 2021/03/17
- Re: [RFC v2 11/13] vhost: Shadow virtqueue buffers forwarding, Jason Wang, 2021/03/17
- Re: [RFC v2 11/13] vhost: Shadow virtqueue buffers forwarding, Eugenio Perez Martin, 2021/03/18
- Re: [RFC v2 11/13] vhost: Shadow virtqueue buffers forwarding, Jason Wang, 2021/03/18
- Re: [RFC v2 11/13] vhost: Shadow virtqueue buffers forwarding, Eugenio Perez Martin, 2021/03/18