[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 08/17] target/ppc: Reduce env->hflags to uint32_t
From: |
Cédric Le Goater |
Subject: |
Re: [PATCH v4 08/17] target/ppc: Reduce env->hflags to uint32_t |
Date: |
Tue, 16 Mar 2021 09:17:11 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 |
On 3/15/21 7:46 PM, Richard Henderson wrote:
> It will be stored in tb->flags, which is also uint32_t,
> so let's use the correct size.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Cédric Le Goater <clg@kaod.org>
Thanks,
C.
> ---
> target/ppc/cpu.h | 4 ++--
> target/ppc/misc_helper.c | 2 +-
> target/ppc/translate.c | 2 +-
> 3 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/target/ppc/cpu.h b/target/ppc/cpu.h
> index 39f35b570c..2abaf56869 100644
> --- a/target/ppc/cpu.h
> +++ b/target/ppc/cpu.h
> @@ -1128,8 +1128,8 @@ struct CPUPPCState {
> bool resume_as_sreset;
> #endif
>
> - /* These resources are used only in QEMU core */
> - target_ulong hflags;
> + /* These resources are used only in TCG */
> + uint32_t hflags;
> target_ulong hflags_compat_nmsr; /* for migration compatibility */
> int immu_idx; /* precomputed MMU index to speed up insn accesses */
> int dmmu_idx; /* precomputed MMU index to speed up data accesses */
> diff --git a/target/ppc/misc_helper.c b/target/ppc/misc_helper.c
> index 63e3147eb4..b04b4d7c6e 100644
> --- a/target/ppc/misc_helper.c
> +++ b/target/ppc/misc_helper.c
> @@ -199,7 +199,7 @@ void helper_store_hid0_601(CPUPPCState *env, target_ulong
> val)
> if ((val ^ hid0) & 0x00000008) {
> /* Change current endianness */
> hreg_compute_hflags(env);
> - qemu_log("%s: set endianness to %c => " TARGET_FMT_lx "\n", __func__,
> + qemu_log("%s: set endianness to %c => %08x\n", __func__,
> val & 0x8 ? 'l' : 'b', env->hflags);
> }
> }
> diff --git a/target/ppc/translate.c b/target/ppc/translate.c
> index a9325a12e5..a85b890bb0 100644
> --- a/target/ppc/translate.c
> +++ b/target/ppc/translate.c
> @@ -7657,7 +7657,7 @@ void ppc_cpu_dump_state(CPUState *cs, FILE *f, int
> flags)
> env->nip, env->lr, env->ctr, cpu_read_xer(env),
> cs->cpu_index);
> qemu_fprintf(f, "MSR " TARGET_FMT_lx " HID0 " TARGET_FMT_lx " HF "
> - TARGET_FMT_lx " iidx %d didx %d\n",
> + "%08x iidx %d didx %d\n",
> env->msr, env->spr[SPR_HID0],
> env->hflags, env->immu_idx, env->dmmu_idx);
> #if !defined(NO_TIMER_DUMP)
>
- Re: [PATCH v4 03/17] target/ppc: Properly sync cpu state with new msr in cpu_load_old, (continued)
Re: [PATCH v4 03/17] target/ppc: Properly sync cpu state with new msr in cpu_load_old, David Gibson, 2021/03/22
[PATCH v4 06/17] target/ppc: Fix comment for MSR_FE{0,1}, Richard Henderson, 2021/03/15
[PATCH v4 05/17] target/ppc: Retain hflags_nmsr only for migration, Richard Henderson, 2021/03/15
[PATCH v4 08/17] target/ppc: Reduce env->hflags to uint32_t, Richard Henderson, 2021/03/15
[PATCH v4 01/17] target/ppc: Move helper_regs.h functions out-of-line, Richard Henderson, 2021/03/15
[PATCH v4 09/17] target/ppc: Put dbcr0 single-step bits into hflags, Richard Henderson, 2021/03/15
[PATCH v4 07/17] target/ppc: Disconnect hflags from MSR, Richard Henderson, 2021/03/15