[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 19/57] tcg/tci: Hoist op_size checking into tci_args_*
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH v5 19/57] tcg/tci: Hoist op_size checking into tci_args_* |
|
Date: |
Tue, 16 Mar 2021 23:23:29 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 |
On 3/11/21 3:39 PM, Richard Henderson wrote:
> This performs the size check while reading the arguments,
> which means that we don't have to arrange for it to be
> done after the operation. Which tidies all of the branches.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> tcg/tci.c | 87 ++++++++++++++++++++++++++++++++++++++++++++++---------
> 1 file changed, 73 insertions(+), 14 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
- Re: [PATCH v5 15/57] tcg/tci: Split out tci_args_rrrr, (continued)
- [PATCH v5 13/57] tcg/tci: Reuse tci_args_l for goto_tb, Richard Henderson, 2021/03/11
- [PATCH v5 12/57] tcg/tci: Reuse tci_args_l for exit_tb, Richard Henderson, 2021/03/11
- [PATCH v5 17/57] tcg/tci: Reduce qemu_ld/st TCGMemOpIdx operand to 32-bits, Richard Henderson, 2021/03/11
- [PATCH v5 18/57] tcg/tci: Split out tci_args_{rrm,rrrm,rrrrm}, Richard Henderson, 2021/03/11
- [PATCH v5 19/57] tcg/tci: Hoist op_size checking into tci_args_*, Richard Henderson, 2021/03/11
- Re: [PATCH v5 19/57] tcg/tci: Hoist op_size checking into tci_args_*,
Philippe Mathieu-Daudé <=
- [PATCH v5 20/57] tcg/tci: Remove tci_disas, Richard Henderson, 2021/03/11
- [PATCH v5 24/57] tcg/tci: Improve tcg_target_call_clobber_regs, Richard Henderson, 2021/03/11
- [PATCH v5 16/57] tcg/tci: Clean up deposit operations, Richard Henderson, 2021/03/11
- [PATCH v5 22/57] tcg: Build ffi data structures for helpers, Richard Henderson, 2021/03/11
- [PATCH v5 21/57] tcg/tci: Implement the disassembler properly, Richard Henderson, 2021/03/11