[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PULL 00/11] pflash patches for 2021-03-16
From: |
Peter Maydell |
Subject: |
Re: [PULL 00/11] pflash patches for 2021-03-16 |
Date: |
Wed, 17 Mar 2021 13:37:45 +0000 |
On Mon, 15 Mar 2021 at 23:37, Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
>
> The following changes since commit 2615a5e433aeb812c300d3a48e1a88e1303e2339:
>
> Merge remote-tracking branch
> 'remotes/stefanha-gitlab/tags/block-pull-request' into staging (2021-03-15
> 19:23:00 +0000)
>
> are available in the Git repository at:
>
> https://github.com/philmd/qemu.git tags/pflash-20210316
>
> for you to fetch changes up to 3b6a1da064ac6ce5256f1f6f16870ea79c2422d0:
>
> hw/block/pflash_cfi: Replace DPRINTF with trace events (2021-03-16 00:28:33
> +0100)
>
> ----------------------------------------------------------------
> Parallel NOR Flash patches queue
>
> - Code movement to ease maintainability
> - Tracing improvements
> ----------------------------------------------------------------
Fails to build on 32-bit and OSX due to format string issues:
In file included from trace/trace-hw_block.c:5:
/Users/pm215/src/qemu-for-merges/hw/block/trace-events:36:38: error:
format specifies type 'unsigned long' but the argument has type
'uint64_t' (aka 'unsigned long long') [-Werror,-Wformat]
, name, offset, len);
^~~
/Users/pm215/src/qemu-for-merges/hw/block/trace-events:33:121: error:
format specifies type 'unsigned long' but the argument has type
'uint64_t' (aka 'unsigned long long') [-Werror,-Wformat]
qemu_log("pflash_write_block_erase " "%s: block erase
offset:0x%" PRIx64 " bytes:0x%lx" "\n", name, offset, len);
~~~ ^~~
%llx
thanks
-- PMM
- [PULL 02/11] hw/block/pflash_cfi01: Extract pflash_cfi01_fill_cfi_table(), (continued)
- [PULL 02/11] hw/block/pflash_cfi01: Extract pflash_cfi01_fill_cfi_table(), Philippe Mathieu-Daudé, 2021/03/15
- [PULL 03/11] hw/block/pflash_cfi02: Extract pflash_cfi02_fill_cfi_table(), Philippe Mathieu-Daudé, 2021/03/15
- [PULL 04/11] hw/block/pflash_cfi02: Set rom_mode to true in pflash_setup_mappings(), Philippe Mathieu-Daudé, 2021/03/15
- [PULL 05/11] hw/block/pflash_cfi02: Open-code pflash_register_memory(rom=false), Philippe Mathieu-Daudé, 2021/03/15
- [PULL 06/11] hw/block/pflash_cfi02: Rename register_memory(true) as mode_read_array, Philippe Mathieu-Daudé, 2021/03/15
- [PULL 07/11] hw/block/pflash_cfi02: Factor out pflash_reset_state_machine(), Philippe Mathieu-Daudé, 2021/03/15
- [PULL 08/11] hw/block/pflash_cfi02: Add DeviceReset method, Philippe Mathieu-Daudé, 2021/03/15
- [PULL 09/11] hw/block/pflash_cfi01: Clarify trace events, Philippe Mathieu-Daudé, 2021/03/15
- [PULL 10/11] hw/block/pflash_cfi01: Correct the type of PFlashCFI01.ro, Philippe Mathieu-Daudé, 2021/03/15
- [PULL 11/11] hw/block/pflash_cfi: Replace DPRINTF with trace events, Philippe Mathieu-Daudé, 2021/03/15
- Re: [PULL 00/11] pflash patches for 2021-03-16,
Peter Maydell <=