[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 4/6] esp: don't underflow fifo when writing to the device
From: |
Alexander Bulekov |
Subject: |
Re: [PATCH v2 4/6] esp: don't underflow fifo when writing to the device |
Date: |
Wed, 17 Mar 2021 20:12:16 -0400 |
On 210317 2302, Mark Cave-Ayland wrote:
> When writing to the device make sure that the fifo is not empty, otherwise the
> fifo will underflow triggering an assert.
>
> Buglink: https://bugs.launchpad.net/qemu/+bug/1909247
> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> ---
> hw/scsi/esp.c | 28 ++++++++++++++++------------
> 1 file changed, 16 insertions(+), 12 deletions(-)
>
Tested-by: Alexander Bulekov <alxndr@bu.edu>
- [PATCH v2 0/6] esp: fix asserts/segfaults discovered by fuzzer, Mark Cave-Ayland, 2021/03/17
- [PATCH v2 1/6] esp: don't underflow cmdfifo if no message out/command data is present, Mark Cave-Ayland, 2021/03/17
- [PATCH v2 2/6] esp: don't overflow cmdfifo if TC is larger than the cmdfifo size, Mark Cave-Ayland, 2021/03/17
- [PATCH v2 3/6] esp: ensure cmdfifo is not empty and current_dev is non-NULL, Mark Cave-Ayland, 2021/03/17
- [PATCH v2 4/6] esp: don't underflow fifo when writing to the device, Mark Cave-Ayland, 2021/03/17
- Re: [PATCH v2 4/6] esp: don't underflow fifo when writing to the device,
Alexander Bulekov <=
- [PATCH v2 5/6] esp: always check current_req is not NULL before use in DMA callbacks, Mark Cave-Ayland, 2021/03/17
- [PATCH v2 6/6] tests/qtest: add tests for am53c974 device, Mark Cave-Ayland, 2021/03/17
- Re: [PATCH v2 0/6] esp: fix asserts/segfaults discovered by fuzzer, Paolo Bonzini, 2021/03/18