[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 05/15] virtio-gpu: move virgl realize + properties
From: |
Gerd Hoffmann |
Subject: |
[PATCH 05/15] virtio-gpu: move virgl realize + properties |
Date: |
Fri, 19 Mar 2021 12:21:37 +0100 |
Move device init (realize) and properties.
Drop the virgl property, the virtio-gpu-gl-device has virgl enabled no
matter what. Just use virtio-gpu-device instead if you don't want
enable virgl and opengl. This simplifies the logic and reduces the test
matrix.
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
include/hw/virtio/virtio-gpu.h | 1 +
hw/display/virtio-gpu-gl.c | 33 +++++++++++++++++++++++++++++++++
hw/display/virtio-gpu.c | 23 +----------------------
3 files changed, 35 insertions(+), 22 deletions(-)
diff --git a/include/hw/virtio/virtio-gpu.h b/include/hw/virtio/virtio-gpu.h
index 8ee6b8fe0fb8..4c1a8faebec9 100644
--- a/include/hw/virtio/virtio-gpu.h
+++ b/include/hw/virtio/virtio-gpu.h
@@ -220,6 +220,7 @@ int virtio_gpu_create_mapping_iov(VirtIOGPU *g,
void virtio_gpu_cleanup_mapping_iov(VirtIOGPU *g,
struct iovec *iov, uint32_t count);
void virtio_gpu_process_cmdq(VirtIOGPU *g);
+void virtio_gpu_device_realize(DeviceState *qdev, Error **errp);
/* virtio-gpu-3d.c */
void virtio_gpu_virgl_process_cmd(VirtIOGPU *g,
diff --git a/hw/display/virtio-gpu-gl.c b/hw/display/virtio-gpu-gl.c
index a477cbe186d3..9b7b5f00d7e6 100644
--- a/hw/display/virtio-gpu-gl.c
+++ b/hw/display/virtio-gpu-gl.c
@@ -16,14 +16,47 @@
#include "qemu/module.h"
#include "qemu/error-report.h"
#include "qapi/error.h"
+#include "sysemu/sysemu.h"
#include "hw/virtio/virtio.h"
#include "hw/virtio/virtio-gpu.h"
#include "hw/virtio/virtio-gpu-bswap.h"
#include "hw/virtio/virtio-gpu-pixman.h"
#include "hw/qdev-properties.h"
+static void virtio_gpu_gl_device_realize(DeviceState *qdev, Error **errp)
+{
+ VirtIOGPU *g = VIRTIO_GPU(qdev);
+
+#if defined(HOST_WORDS_BIGENDIAN)
+ error_setg(errp, "virgl is not supported on bigendian platforms");
+ return;
+#endif
+
+ if (!display_opengl) {
+ error_setg(errp, "opengl is not available");
+ return;
+ }
+
+ g->parent_obj.conf.flags |= (1 << VIRTIO_GPU_FLAG_VIRGL_ENABLED);
+ VIRTIO_GPU_BASE(g)->virtio_config.num_capsets =
+ virtio_gpu_virgl_get_num_capsets(g);
+
+ virtio_gpu_device_realize(qdev, errp);
+}
+
+static Property virtio_gpu_gl_properties[] = {
+ DEFINE_PROP_BIT("stats", VirtIOGPU, parent_obj.conf.flags,
+ VIRTIO_GPU_FLAG_STATS_ENABLED, false),
+ DEFINE_PROP_END_OF_LIST(),
+};
+
static void virtio_gpu_gl_class_init(ObjectClass *klass, void *data)
{
+ DeviceClass *dc = DEVICE_CLASS(klass);
+ VirtioDeviceClass *vdc = VIRTIO_DEVICE_CLASS(klass);
+
+ vdc->realize = virtio_gpu_gl_device_realize;
+ device_class_set_props(dc, virtio_gpu_gl_properties);
}
static const TypeInfo virtio_gpu_gl_info = {
diff --git a/hw/display/virtio-gpu.c b/hw/display/virtio-gpu.c
index c9f5e36fd076..2ee6ba756aba 100644
--- a/hw/display/virtio-gpu.c
+++ b/hw/display/virtio-gpu.c
@@ -1105,25 +1105,10 @@ static int virtio_gpu_load(QEMUFile *f, void *opaque,
size_t size,
return 0;
}
-static void virtio_gpu_device_realize(DeviceState *qdev, Error **errp)
+void virtio_gpu_device_realize(DeviceState *qdev, Error **errp)
{
VirtIODevice *vdev = VIRTIO_DEVICE(qdev);
VirtIOGPU *g = VIRTIO_GPU(qdev);
- bool have_virgl;
-
-#if !defined(CONFIG_VIRGL) || defined(HOST_WORDS_BIGENDIAN)
- have_virgl = false;
-#else
- have_virgl = display_opengl;
-#endif
- if (!have_virgl) {
- g->parent_obj.conf.flags &= ~(1 << VIRTIO_GPU_FLAG_VIRGL_ENABLED);
- } else {
-#if defined(CONFIG_VIRGL)
- VIRTIO_GPU_BASE(g)->virtio_config.num_capsets =
- virtio_gpu_virgl_get_num_capsets(g);
-#endif
- }
if (!virtio_gpu_base_device_realize(qdev,
virtio_gpu_handle_ctrl_cb,
@@ -1235,12 +1220,6 @@ static Property virtio_gpu_properties[] = {
VIRTIO_GPU_BASE_PROPERTIES(VirtIOGPU, parent_obj.conf),
DEFINE_PROP_SIZE("max_hostmem", VirtIOGPU, conf_max_hostmem,
256 * MiB),
-#ifdef CONFIG_VIRGL
- DEFINE_PROP_BIT("virgl", VirtIOGPU, parent_obj.conf.flags,
- VIRTIO_GPU_FLAG_VIRGL_ENABLED, true),
- DEFINE_PROP_BIT("stats", VirtIOGPU, parent_obj.conf.flags,
- VIRTIO_GPU_FLAG_STATS_ENABLED, false),
-#endif
DEFINE_PROP_END_OF_LIST(),
};
--
2.30.2
- [PATCH 00/15] virtio-gpu: split into two devices., Gerd Hoffmann, 2021/03/19
- [PATCH 03/15] virtio-gpu: add virtio-gpu-gl-pci, Gerd Hoffmann, 2021/03/19
- [PATCH 01/15] virtio-gpu: rename virgl source file., Gerd Hoffmann, 2021/03/19
- [PATCH 02/15] virtio-gpu: add virtio-gpu-gl-device, Gerd Hoffmann, 2021/03/19
- [PATCH 04/15] virtio-gpu: add virtio-vga-gl, Gerd Hoffmann, 2021/03/19
- [PATCH 12/15] virtio-gpu: drop VIRGL() macro, Gerd Hoffmann, 2021/03/19
- [PATCH 07/15] virtio-gpu: use class function for ctrl queue handlers, Gerd Hoffmann, 2021/03/19
- [PATCH 11/15] virtio-gpu: move update_cursor_data, Gerd Hoffmann, 2021/03/19
- [PATCH 09/15] virtio-gpu: move virgl gl_flushed, Gerd Hoffmann, 2021/03/19
- [PATCH 05/15] virtio-gpu: move virgl realize + properties,
Gerd Hoffmann <=
- [PATCH 06/15] virtio-gpu: move virgl reset, Gerd Hoffmann, 2021/03/19
- [PATCH 08/15] virtio-gpu: move virgl handle_ctrl, Gerd Hoffmann, 2021/03/19
- [PATCH 13/15] virtio-gpu: move virtio-gpu-gl-device to separate module, Gerd Hoffmann, 2021/03/19
- [PATCH 15/15] virtio-gpu: move fields to struct VirtIOGPUGL, Gerd Hoffmann, 2021/03/19
- [PATCH 10/15] virtio-gpu: move virgl process_cmd, Gerd Hoffmann, 2021/03/19
- [PATCH 14/15] virtio-gpu: drop use_virgl_renderer, Gerd Hoffmann, 2021/03/19
- Re: [PATCH 00/15] virtio-gpu: split into two devices., no-reply, 2021/03/19
- Re: [PATCH 00/15] virtio-gpu: split into two devices., Marc-André Lureau, 2021/03/19