[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] floppy: add a regression test for CVE-2020-25741
From: |
Alexander Bulekov |
Subject: |
Re: [PATCH 1/2] floppy: add a regression test for CVE-2020-25741 |
Date: |
Fri, 19 Mar 2021 10:51:50 -0400 |
On 210319 1054, Markus Armbruster wrote:
> Paolo Bonzini <pbonzini@redhat.com> writes:
>
> > On 19/03/21 06:53, Markus Armbruster wrote:
> >> I guess this is a reproducer. Please also describe actual and expected
> >> result. Same for PATCH 2.
> >
> > Isn't it in the patch itself?
>
> A commit message should tell me what the patch is trying to accomplish.
>
> This commit message's title tells me it's a test for a CVE. Okay. The
> body additionally gives me the reproducer. To be useful, a reproducer
> needs to come with actual and expected result. Yes, I can find those in
> the patch. But I could find the reproducer there, too. If you're nice
> enough to save me the trouble of digging through the patch for the
> reproducer (thanks), please consider saving me the trouble digging for
> the information I need to make use of it (thanks again). That's all :)
>
> [...]
>
Ok sounds good. I posted this in-reply-to patch [1] from August 2020,
which had a stacktrace, and I hoped that would provide enough context.
However, that depends on the email-viewer and I see how that context
would be lost if/once these reproducer patches are applied.
[1]
https://lore.kernel.org/qemu-devel/20200827113806.1850687-1-ppandit@redhat.com/
(https://lists.nongnu.org/archive doesn't display this discussion
as a child of that message)