[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 06/13] net/colo-compare.c: Optimize removal of secondary packet
From: |
Jason Wang |
Subject: |
[PULL 06/13] net/colo-compare.c: Optimize removal of secondary packet |
Date: |
Mon, 22 Mar 2021 18:08:05 +0800 |
From: Lukas Straub <lukasstraub2@web.de>
g_queue_remove needs to look up the list entry first, but we
already have it as result and can remove it directly with
g_queue_delete_link.
Signed-off-by: Lukas Straub <lukasstraub2@web.de>
Signed-off-by: Zhang Chen <chen.zhang@intel.com>
Reviewed-by: Zhang Chen <chen.zhang@intel.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
---
net/colo-compare.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/colo-compare.c b/net/colo-compare.c
index 2e819ff..9d1ad99 100644
--- a/net/colo-compare.c
+++ b/net/colo-compare.c
@@ -691,7 +691,7 @@ static void colo_compare_packet(CompareState *s, Connection
*conn,
if (result) {
colo_release_primary_pkt(s, pkt);
packet_destroy(result->data, NULL);
- g_queue_remove(&conn->secondary_list, result->data);
+ g_queue_delete_link(&conn->secondary_list, result);
} else {
/*
* If one packet arrive late, the secondary_list or
--
2.7.4
- [PULL 00/13] Net patches, Jason Wang, 2021/03/22
- [PULL 01/13] net: eth: Add a helper to pad a short Ethernet frame, Jason Wang, 2021/03/22
- [PULL 03/13] net: Pad short frames to minimum size before sending from SLiRP/TAP, Jason Wang, 2021/03/22
- [PULL 02/13] net: Add a 'do_not_pad" to NetClientState, Jason Wang, 2021/03/22
- [PULL 04/13] hw/net: virtio-net: Initialize nc->do_not_pad to true, Jason Wang, 2021/03/22
- [PULL 05/13] net/colo-compare.c: Fix memory leak for non-tcp packet, Jason Wang, 2021/03/22
- [PULL 06/13] net/colo-compare.c: Optimize removal of secondary packet,
Jason Wang <=
- [PULL 07/13] net/eth: Use correct in6_address offset in _eth_get_rss_ex_dst_addr(), Jason Wang, 2021/03/22
- [PULL 08/13] net/eth: Simplify _eth_get_rss_ex_dst_addr(), Jason Wang, 2021/03/22
- [PULL 09/13] net/eth: Better describe _eth_get_rss_ex_dst_addr's offset argument, Jason Wang, 2021/03/22
- [PULL 10/13] net/eth: Check size earlier in _eth_get_rss_ex_dst_addr(), Jason Wang, 2021/03/22
- [PULL 11/13] net/eth: Check iovec has enough data earlier, Jason Wang, 2021/03/22
- [PULL 12/13] net/eth: Read ip6_ext_hdr_routing buffer before accessing it, Jason Wang, 2021/03/22
- [PULL 13/13] net/eth: Add an assert() and invert if() statement to simplify code, Jason Wang, 2021/03/22
- Re: [PULL 00/13] Net patches, Peter Maydell, 2021/03/22