[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH V4 3/7] qapi/net: Add new QMP command for COLO passthrough
From: |
Markus Armbruster |
Subject: |
Re: [PATCH V4 3/7] qapi/net: Add new QMP command for COLO passthrough |
Date: |
Tue, 23 Mar 2021 10:58:21 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) |
"Zhang, Chen" <chen.zhang@intel.com> writes:
>> -----Original Message-----
>> From: Markus Armbruster <armbru@redhat.com>
[...]
>> Now let's look at colo-passthrough-del. I figure it is for deleting the
>> kind of
>> things colo-passthrough-add adds.
>>
>
> Yes.
>
>> What exactly is deleted? The thing created with the exact same arguments?
>>
>
> Delete the rule from the module's private bypass list.
> When user input a rule, the colo-passthrough-del will find the specific
> module by the object ID,
> Then delete the rule.
>
>> This would be unusual. Commonly, FOO-add and FOO-del both take a string
>> ID argument. The FOO created by FOO-add remembers its ID, and FOO-del
>> deletes by ID.
>
> The ID not for rules itself, it just logged the modules(ID tagged) affected
> by the rule.
I'm not sure I understand.
If you're pointing out that existing colo-passthrough-del parameter @id
is not suitable for use as unique rule ID: you can always add another
parameter that is suitable.
[PATCH V4 5/7] net/colo-compare: Move data structure and define to .h file., Zhang Chen, 2021/03/19
[PATCH V4 7/7] net/net.c: Add handler for COLO passthrough connection, Zhang Chen, 2021/03/19
[PATCH V4 6/7] net/colo-compare: Add passthrough list to CompareState, Zhang Chen, 2021/03/19
[PATCH V4 4/7] hmp-commands: Add new HMP command for COLO passthrough, Zhang Chen, 2021/03/19