[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 07/19] qapi/expr.py: move string check upwards in check_type
From: |
John Snow |
Subject: |
[PATCH v4 07/19] qapi/expr.py: move string check upwards in check_type |
Date: |
Thu, 25 Mar 2021 02:03:44 -0400 |
For readability purposes only, shimmy the early return upwards to the
top of the function, so cases proceed in order from least to most
complex.
Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
Reviewed-by: Cleber Rosa <crosa@redhat.com>
---
scripts/qapi/expr.py | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/scripts/qapi/expr.py b/scripts/qapi/expr.py
index 2a2cf7064f..73e7d8cb0d 100644
--- a/scripts/qapi/expr.py
+++ b/scripts/qapi/expr.py
@@ -169,6 +169,10 @@ def check_type(value, info, source,
if value is None:
return
+ # Type name
+ if isinstance(value, str):
+ return
+
# Array type
if isinstance(value, list):
if not allow_array:
@@ -179,10 +183,6 @@ def check_type(value, info, source,
source)
return
- # Type name
- if isinstance(value, str):
- return
-
# Anonymous type
if not allow_dict:
--
2.30.2
- Re: [PATCH v4 01/19] qapi/expr: Comment cleanup, (continued)
[PATCH v4 03/19] qapi/expr.py: Remove 'info' argument from nested check_if_str, John Snow, 2021/03/25
[PATCH v4 04/19] qapi/expr.py: Check for dict instead of OrderedDict, John Snow, 2021/03/25
[PATCH v4 07/19] qapi/expr.py: move string check upwards in check_type,
John Snow <=
[PATCH v4 05/19] qapi/expr.py: constrain incoming expression types, John Snow, 2021/03/25
[PATCH v4 06/19] qapi/expr.py: Add assertion for union type 'check_dict', John Snow, 2021/03/25
[PATCH v4 08/19] qapi: add tests for invalid 'data' field type, John Snow, 2021/03/25
[PATCH v4 09/19] qapi/expr.py: Check type of 'data' member, John Snow, 2021/03/25