[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 0/4] yank: Add chardev tests and fixes
From: |
Lukas Straub |
Subject: |
Re: [PATCH v3 0/4] yank: Add chardev tests and fixes |
Date: |
Thu, 25 Mar 2021 17:03:47 +0100 |
On Tue, 23 Mar 2021 18:57:32 +0100
Lukas Straub <lukasstraub2@web.de> wrote:
> Hello Everyone,
> These patches increase test coverage for yank, add tests and fix bugs and
> crashes in yank in combination with chardev-change.
> Please Review.
>
> Regards,
> Lukas Straub
>
> Changes:
> -v3:
> -Base on <cover.1616521341.git.lukasstraub2@web.de>
> ([PATCH 0/2] yank: Always link full yank code)
> -Drop patch 1 (tests: Use the normal yank code instead of stubs in relevant
> tests)
>
> -v2:
> -test: add license
> -test: factorize testcases to a single function
> -test: test chardev_change with initialization of new chardev failing
> -fix chardev_change with initialization of new chardev failing
> -add reviewed-by and tested-by tags
>
> Based-on: <cover.1616521341.git.lukasstraub2@web.de>
> ([PATCH 0/2] yank: Always link full yank code)
>
> Lukas Straub (4):
> tests: Add tests for yank with the chardev-change case
> chardev/char.c: Move object_property_try_add_child out of chardev_new
> chardev/char.c: Always pass id to chardev_new
> chardev: Fix yank with the chardev-change case
>
> MAINTAINERS | 1 +
> chardev/char-socket.c | 20 +++-
> chardev/char.c | 77 +++++++++++-----
> include/chardev/char.h | 3 +
> tests/unit/meson.build | 3 +-
> tests/unit/test-yank.c | 201 +++++++++++++++++++++++++++++++++++++++++
> 6 files changed, 276 insertions(+), 29 deletions(-)
> create mode 100644 tests/unit/test-yank.c
>
> --
> 2.30.2
Ping. It would be cool if I could submit a PR for this for rc1.
Regards,
Lukas Straub
--
pgpOqH7EyCeX3.pgp
Description: OpenPGP digital signature