[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 0/4] yank: Add chardev tests and fixes
From: |
no-reply |
Subject: |
Re: [PATCH v4 0/4] yank: Add chardev tests and fixes |
Date: |
Fri, 26 Mar 2021 01:09:46 -0700 (PDT) |
Patchew URL: cover.1616744509.git.lukasstraub2@web.de/">https://patchew.org/QEMU/cover.1616744509.git.lukasstraub2@web.de/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: cover.1616744509.git.lukasstraub2@web.de
Subject: [PATCH v4 0/4] yank: Add chardev tests and fixes
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
- [tag update] patchew/20210323183701.281152-1-f4bug@amsat.org ->
patchew/20210323183701.281152-1-f4bug@amsat.org
* [new tag] patchew/cover.1616744509.git.lukasstraub2@web.de ->
patchew/cover.1616744509.git.lukasstraub2@web.de
Switched to a new branch 'test'
b0e7602 tests: Add tests for yank with the chardev-change case
f065000 chardev: Fix yank with the chardev-change case
e006dcc chardev/char.c: Always pass id to chardev_new
8a11307 chardev/char.c: Move object_property_try_add_child out of chardev_new
=== OUTPUT BEGIN ===
1/4 Checking commit 8a113074e682 (chardev/char.c: Move
object_property_try_add_child out of chardev_new)
2/4 Checking commit e006dccfdf7e (chardev/char.c: Always pass id to chardev_new)
3/4 Checking commit f06500035576 (chardev: Fix yank with the chardev-change
case)
4/4 Checking commit b0e7602e4800 (tests: Add tests for yank with the
chardev-change case)
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#228: FILE: tests/unit/test-yank.c:179:
+#define CHAR_CHANGE_TEST(name, _old_yank, _new_yank)
\
+ g_test_add_data_func("/yank/char_change/success/" # name,
\
+ &(CharChangeTestConfig) { .addr = &tcpaddr,
\
+ .old_yank =
(_old_yank),\
+ .new_yank =
(_new_yank),\
+ .fail = false },
\
+ char_change_test);
\
+ g_test_add_data_func("/yank/char_change/fail/" # name,
\
+ &(CharChangeTestConfig) { .addr = &tcpaddr,
\
+ .old_yank =
(_old_yank),\
+ .new_yank =
(_new_yank),\
+ .fail = true },
\
+ char_change_test);
total: 1 errors, 0 warnings, 215 lines checked
Patch 4/4 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
cover.1616744509.git.lukasstraub2@web.de/testing.checkpatch/?type=message">http://patchew.org/logs/cover.1616744509.git.lukasstraub2@web.de/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
- [PATCH v4 0/4] yank: Add chardev tests and fixes, Lukas Straub, 2021/03/26
- [PATCH v4 1/4] chardev/char.c: Move object_property_try_add_child out of chardev_new, Lukas Straub, 2021/03/26
- [PATCH v4 2/4] chardev/char.c: Always pass id to chardev_new, Lukas Straub, 2021/03/26
- [PATCH v4 3/4] chardev: Fix yank with the chardev-change case, Lukas Straub, 2021/03/26
- [PATCH v4 4/4] tests: Add tests for yank with the chardev-change case, Lukas Straub, 2021/03/26
- Re: [PATCH v4 0/4] yank: Add chardev tests and fixes,
no-reply <=
- Re: [PATCH v4 0/4] yank: Add chardev tests and fixes, Marc-André Lureau, 2021/03/26