[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 3/7] ui/vdagent: add mouse support
From: |
Markus Armbruster |
Subject: |
Re: [PATCH v3 3/7] ui/vdagent: add mouse support |
Date: |
Fri, 26 Mar 2021 15:59:11 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) |
Gerd Hoffmann <kraxel@redhat.com> writes:
> This patch adds support for mouse messages to the vdagent
> implementation. This can be enabled/disabled using the new
> 'mouse' parameter for the vdagent chardev. Default is on.
>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
[...]
> diff --git a/qapi/char.json b/qapi/char.json
> index 6e565ce42753..586ef2137368 100644
> --- a/qapi/char.json
> +++ b/qapi/char.json
> @@ -395,10 +395,12 @@
> #
> # Configuration info for vdagent.
> #
> +# @mouse: enable/disable mouse, default is enabled.
> +#
> # Since: 6.0
> ##
> { 'struct': 'ChardevVDAgent',
> - 'data': { },
> + 'data': { '*mouse' : 'bool' },
> 'base': 'ChardevCommon' }
>
> ##
Ah, now ChardevVDAgent isn't the same as ChardevCommon anymore.
Please format like
'data': { '*mouse': 'bool' },
for consistency with the rest of the file.
Acked-by: Markus Armbruster <armbru@redhat.com>
- [PATCH v3 0/7] ui: add vdagent implementation and clipboard support., Gerd Hoffmann, 2021/03/26
- [PATCH v3 1/7] ui: add clipboard infrastructure, Gerd Hoffmann, 2021/03/26
- [PATCH v3 2/7] ui/vdagent: core infrastructure, Gerd Hoffmann, 2021/03/26
- [PATCH v3 5/7] ui/vnc: clipboard support, Gerd Hoffmann, 2021/03/26
- [PATCH v3 7/7] ui/gtk: add clipboard support, Gerd Hoffmann, 2021/03/26
- [PATCH v3 6/7] ui/gtk: move struct GtkDisplayState to ui/gtk.h, Gerd Hoffmann, 2021/03/26
- [PATCH v3 4/7] ui/vdagent: add clipboard support, Gerd Hoffmann, 2021/03/26
- [PATCH v3 3/7] ui/vdagent: add mouse support, Gerd Hoffmann, 2021/03/26
- Re: [PATCH v3 3/7] ui/vdagent: add mouse support,
Markus Armbruster <=
- Re: [PATCH v3 0/7] ui: add vdagent implementation and clipboard support., no-reply, 2021/03/26