|
From: | Richard Henderson |
Subject: | Re: [RFC v12 38/65] target/arm: remove broad "else" statements when checking accels |
Date: | Sun, 28 Mar 2021 11:11:35 -0600 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 |
On 3/26/21 1:36 PM, Claudio Fontana wrote:
@@ -638,24 +638,21 @@ static int cpu_pre_save(void *opaque)if (tcg_enabled()) {pmu_op_start(&cpu->env); + if (!write_cpustate_to_list(cpu, false)) { + /* This should never fail. */ + abort(); + } } - if (kvm_enabled()) { if (!write_kvmstate_to_list(cpu)) { /* This should never fail */ abort(); } - /* * kvm_arm_cpu_pre_save() must be called after * write_kvmstate_to_list() */ kvm_arm_cpu_pre_save(cpu); - } else { - if (!write_cpustate_to_list(cpu, false)) { - /* This should never fail. */ - abort(); - } }
Hmm. Not perfect. I can't decide on if (tcg) { ... } else if (kvm) { ... } or if (tcg) { pmu } if (kvm || tcg) { write_cpustate_to_list } if (kvm) { rest of kvm stuff } r~
[Prev in Thread] | Current Thread | [Next in Thread] |