|
From: | Richard Henderson |
Subject: | Re: [RFC v12 53/65] target/arm: restrict rebuild_hflags_a64 to TARGET_AARCH64 |
Date: | Sun, 28 Mar 2021 13:02:57 -0600 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 |
On 3/28/21 12:34 PM, Richard Henderson wrote:
On 3/26/21 1:36 PM, Claudio Fontana wrote:@@ -1084,6 +1084,8 @@ static uint32_t rebuild_hflags_a32(CPUARMState *env, int fp_el,return rebuild_hflags_common_32(env, fp_el, mmu_idx, flags); } +#ifdef TARGET_AARCH64 + static uint32_t rebuild_hflags_a64(CPUARMState *env, int el, int fp_el, ARMMMUIdx mmu_idx) {@@ -1204,6 +1206,16 @@ static uint32_t rebuild_hflags_a64(CPUARMState *env, int el, int fp_el,return rebuild_hflags_common(env, fp_el, mmu_idx, flags); } +#else + +static inline uint32_t rebuild_hflags_a64(CPUARMState *env, int el, int fp_el, + ARMMMUIdx mmu_idx) +{ + return 0; +} +/ +#endif /* TARGET_AARCH64 */Is this even necessary? Isn't it removed by the is_a64 test?
Ah, this for patch 59, sve_zcr_len_for_el. You could perhaps mention that. Also, the #else could be just the declaration uint32_t rebuild_hflags_a64(CPUARMState *env, int el, int fp_el, ARMMMUIdx mmu_idx) QEMU_ERROR;which produces a nice compile-time error message when the function is not optimized away.
r~
[Prev in Thread] | Current Thread | [Next in Thread] |