[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/8] hw/riscv: sifive_u: Switch to use qemu_fdt_setprop_strin
From: |
Alistair Francis |
Subject: |
Re: [PATCH 1/8] hw/riscv: sifive_u: Switch to use qemu_fdt_setprop_string_array() helper |
Date: |
Wed, 31 Mar 2021 11:40:51 -0400 |
On Mon, Mar 29, 2021 at 1:08 PM Bin Meng <bmeng.cn@gmail.com> wrote:
>
> From: Bin Meng <bin.meng@windriver.com>
>
> Since commit 78da6a1bca22 ("device_tree: add qemu_fdt_setprop_string_array
> helper"),
> we can use the new helper to set the clock name for the ethernet
> controller node.
>
> Signed-off-by: Bin Meng <bin.meng@windriver.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Alistair
> ---
>
> hw/riscv/sifive_u.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/hw/riscv/sifive_u.c b/hw/riscv/sifive_u.c
> index 7b59942369..f06b3b2e64 100644
> --- a/hw/riscv/sifive_u.c
> +++ b/hw/riscv/sifive_u.c
> @@ -96,7 +96,7 @@ static void create_fdt(SiFiveUState *s, const MemMapEntry
> *memmap,
> int cpu;
> uint32_t *cells;
> char *nodename;
> - char ethclk_names[] = "pclk\0hclk";
> + const char *ethclk_names[2] = { "pclk", "hclk" };
> uint32_t plic_phandle, prci_phandle, gpio_phandle, phandle = 1;
> uint32_t hfclk_phandle, rtcclk_phandle, phy_phandle;
>
> @@ -413,8 +413,8 @@ static void create_fdt(SiFiveUState *s, const MemMapEntry
> *memmap,
> qemu_fdt_setprop_cell(fdt, nodename, "interrupts", SIFIVE_U_GEM_IRQ);
> qemu_fdt_setprop_cells(fdt, nodename, "clocks",
> prci_phandle, PRCI_CLK_GEMGXLPLL, prci_phandle, PRCI_CLK_GEMGXLPLL);
> - qemu_fdt_setprop(fdt, nodename, "clock-names", ethclk_names,
> - sizeof(ethclk_names));
> + qemu_fdt_setprop_string_array(fdt, nodename, "clock-names",
> + (char **)ðclk_names, ARRAY_SIZE(ethclk_names));
> qemu_fdt_setprop(fdt, nodename, "local-mac-address",
> s->soc.gem.conf.macaddr.a, ETH_ALEN);
> qemu_fdt_setprop_cell(fdt, nodename, "#address-cells", 1);
> --
> 2.25.1
>
>
- [PATCH 4/8] hw/riscv: Support the official PLIC DT bindings, (continued)
- [PATCH 4/8] hw/riscv: Support the official PLIC DT bindings, Bin Meng, 2021/03/29
- [PATCH 6/8] docs/system/riscv: sifive_u: Document '-dtb' usage, Bin Meng, 2021/03/29
- [PATCH 5/8] docs/system/riscv: Correct the indentation level of supported devices, Bin Meng, 2021/03/29
- [PATCH 7/8] hw/riscv: Use macros for BIOS image names, Bin Meng, 2021/03/29
- [PATCH 8/8] hw/riscv: microchip_pfsoc: Support direct kernel boot, Bin Meng, 2021/03/29
- Re: [PATCH 1/8] hw/riscv: sifive_u: Switch to use qemu_fdt_setprop_string_array() helper,
Alistair Francis <=
- Re: [PATCH 1/8] hw/riscv: sifive_u: Switch to use qemu_fdt_setprop_string_array() helper, Richard Henderson, 2021/03/31