[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/6] plugins/cache: Fixed a bug with destroying FIFO metadata
From: |
Alex Bennée |
Subject: |
Re: [PATCH 1/6] plugins/cache: Fixed a bug with destroying FIFO metadata |
Date: |
Mon, 19 Jul 2021 10:21:21 +0100 |
User-agent: |
mu4e 1.5.14; emacs 28.0.50 |
Mahmoud Mandour <ma.mandourr@gmail.com> writes:
> This manifests itself when associativity degree is greater than the
> number of sets and FIFO is used, otherwise it's also a memory leak
> whenever FIFO was used.
>
> Signed-off-by: Mahmoud Mandour <ma.mandourr@gmail.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> contrib/plugins/cache.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/contrib/plugins/cache.c b/contrib/plugins/cache.c
> index bf0d2f6097..4a71602639 100644
> --- a/contrib/plugins/cache.c
> +++ b/contrib/plugins/cache.c
> @@ -200,7 +200,7 @@ static void fifo_destroy(Cache *cache)
> {
> int i;
>
> - for (i = 0; i < cache->assoc; i++) {
> + for (i = 0; i < cache->num_sets; i++) {
> g_queue_free(cache->sets[i].fifo_queue);
> }
> }
--
Alex Bennée
[PATCH 5/6] docs/devel/tcg-plugins: added cores arg to cache plugin, Mahmoud Mandour, 2021/07/14
[PATCH 4/6] plugins/cache: Supported multicore cache modelling, Mahmoud Mandour, 2021/07/14
[PATCH 2/6] plugins/cache: limited the scope of a mutex lock, Mahmoud Mandour, 2021/07/14