[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 12/17] iotests/297: Add 'directory' argument to run_linters
From: |
John Snow |
Subject: |
[PATCH v2 12/17] iotests/297: Add 'directory' argument to run_linters |
Date: |
Tue, 20 Jul 2021 13:33:31 -0400 |
Allow run_linters to work well if it's executed from a different
directory.
Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
---
tests/qemu-iotests/297 | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tests/qemu-iotests/297 b/tests/qemu-iotests/297
index 961c9170d21..b2bf7928c5d 100755
--- a/tests/qemu-iotests/297
+++ b/tests/qemu-iotests/297
@@ -71,6 +71,7 @@ def get_test_files(directory: str = '.') -> List[str]:
def run_linters(
files: List[str],
+ directory: str = '.',
env: Optional[Mapping[str, str]] = None,
) -> None:
@@ -81,6 +82,7 @@ def run_linters(
# fixed (in tests, at least)
subprocess.run(
('python3', '-m', 'pylint', '--score=n', '--notes=FIXME,XXX', *files),
+ cwd=directory,
env=env,
check=False,
)
@@ -108,6 +110,7 @@ def run_linters(
'--namespace-packages',
filename,
),
+ cwd=directory,
env=env,
check=False,
stdout=subprocess.PIPE,
--
2.31.1
- Re: [PATCH v2 02/17] iotests: use subprocess.DEVNULL instead of open("/dev/null"), (continued)
- [PATCH v2 06/17] iotests/297: modify is_python_file to work from any CWD, John Snow, 2021/07/20
- [PATCH v2 05/17] iotests/migrate-bitmaps-test: delint, John Snow, 2021/07/20
- [PATCH v2 07/17] iotests/297: Add get_files() function, John Snow, 2021/07/20
- [PATCH v2 08/17] iotests/297: Include sub-directories when finding tests to lint, John Snow, 2021/07/20
- [PATCH v2 09/17] iotests/297: Don't rely on distro-specific linter binaries, John Snow, 2021/07/20
- [PATCH v2 11/17] iotests/297: Separate environment setup from test execution, John Snow, 2021/07/20
- [PATCH v2 10/17] iotests/297: Create main() function, John Snow, 2021/07/20
- [PATCH v2 13/17] iotests/297: return error code from run_linters(), John Snow, 2021/07/20
- [PATCH v2 12/17] iotests/297: Add 'directory' argument to run_linters,
John Snow <=
- [PATCH v2 14/17] iotests/297: split linters.py off from 297, John Snow, 2021/07/20
- [PATCH v2 15/17] iotests/linters: Add entry point for Python CI linters, John Snow, 2021/07/20
- [PATCH v2 16/17] python: Add iotest linters to test suite, John Snow, 2021/07/20
- [PATCH v2 17/17] iotests/linters: check mypy files all at once, John Snow, 2021/07/20
- Re: [PATCH v2 00/17] python/iotests: Run iotest linters during Python CI, John Snow, 2021/07/20