Re: [PATCH v2] Hexagon (target/hexagon) probe the stores in a packet at start of commit

[Richard Henderson]

On 9/30/21 5:16 PM, Taylor Simpson wrote:
> +    } else if (has_store_s0 && has_store_s1) {
> +        TCGv mem_idx = tcg_const_tl(ctx->mem_idx);
> +        gen_helper_probe_pkt_scalar_store_s0(cpu_env, mem_idx);
> +        tcg_temp_free(mem_idx);
> +    }

So we're assuming that the s1 store happens first?
If so, you could expand the comment above.

Otherwise, it looks good.
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~