[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 02/13] qapi/gen: use dict.items() to iterate over _modules
From: |
Markus Armbruster |
Subject: |
[PULL 02/13] qapi/gen: use dict.items() to iterate over _modules |
Date: |
Sat, 2 Oct 2021 11:56:44 +0200 |
From: John Snow <jsnow@redhat.com>
New pylint warning. I could silence it, but this is the only occurrence
in the entire tree, including everything in iotests/ and python/. Easier
to just change this one instance.
(The warning is emitted in cases where you are fetching the values
anyway, so you may as well just take advantage of the iterator to avoid
redundant lookups.)
Signed-off-by: John Snow <jsnow@redhat.com>
Message-Id: <20210930205716.1148693-3-jsnow@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
scripts/qapi/gen.py | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/scripts/qapi/gen.py b/scripts/qapi/gen.py
index ab26d5c937..2ec1e7b3b6 100644
--- a/scripts/qapi/gen.py
+++ b/scripts/qapi/gen.py
@@ -296,10 +296,9 @@ def _temp_module(self, name: str) -> Iterator[None]:
self._current_module = old_module
def write(self, output_dir: str, opt_builtins: bool = False) -> None:
- for name in self._module:
+ for name, (genc, genh) in self._module.items():
if QAPISchemaModule.is_builtin_module(name) and not opt_builtins:
continue
- (genc, genh) = self._module[name]
genc.write(output_dir)
genh.write(output_dir)
--
2.31.1
- [PULL 00/13] QAPI patches patches for 2021-10-02, Markus Armbruster, 2021/10/02
- [PULL 02/13] qapi/gen: use dict.items() to iterate over _modules,
Markus Armbruster <=
- [PULL 07/13] qapi/parser: Introduce NullSection, Markus Armbruster, 2021/10/02
- [PULL 11/13] qapi/parser: enable mypy checks, Markus Armbruster, 2021/10/02
- [PULL 12/13] qapi/parser: Silence too-few-public-methods warning, Markus Armbruster, 2021/10/02
- [PULL 01/13] qapi/pylintrc: ignore 'consider-using-f-string' warning, Markus Armbruster, 2021/10/02
- [PULL 04/13] qapi: Add spaces after symbol declaration for consistency, Markus Armbruster, 2021/10/02
- [PULL 09/13] qapi/parser: add type hint annotations (QAPIDoc), Markus Armbruster, 2021/10/02
- [PULL 06/13] qapi/parser: clarify _end_section() logic, Markus Armbruster, 2021/10/02
- [PULL 13/13] qapi/parser: enable pylint checks, Markus Armbruster, 2021/10/02
- [PULL 05/13] qapi/parser: remove FIXME comment from _append_body_line, Markus Armbruster, 2021/10/02
- [PULL 03/13] qapi/parser: fix unused check_args_section arguments, Markus Armbruster, 2021/10/02