[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 10/13] qapi/parser: Add FIXME for consolidating JSON-related types
From: |
Markus Armbruster |
Subject: |
[PULL 10/13] qapi/parser: Add FIXME for consolidating JSON-related types |
Date: |
Sat, 2 Oct 2021 11:56:52 +0200 |
From: John Snow <jsnow@redhat.com>
The fix for this comment is forthcoming in a future commit, but this
will keep me honest. The linting configuration in ./python/setup.cfg
prohibits 'FIXME' comments. A goal of this long-running series is to
move ./scripts/qapi to ./python/qemu/qapi so that the QAPI generator is
regularly type-checked by GitLab CI.
This comment is a time-bomb to force me to address this issue prior to
that step.
Signed-off-by: John Snow <jsnow@redhat.com>
Message-Id: <20210930205716.1148693-11-jsnow@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
scripts/qapi/parser.py | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/scripts/qapi/parser.py b/scripts/qapi/parser.py
index 73c1c4ef59..0265b47b95 100644
--- a/scripts/qapi/parser.py
+++ b/scripts/qapi/parser.py
@@ -43,6 +43,10 @@
# Return value alias for get_expr().
_ExprValue = Union[List[object], Dict[str, object], str, bool]
+# FIXME: Consolidate and centralize definitions for TopLevelExpr,
+# _ExprValue, _JSONValue, and _JSONObject; currently scattered across
+# several modules.
+
class QAPIParseError(QAPISourceError):
"""Error class for all QAPI schema parsing errors."""
--
2.31.1
- [PULL 07/13] qapi/parser: Introduce NullSection, (continued)
- [PULL 07/13] qapi/parser: Introduce NullSection, Markus Armbruster, 2021/10/02
- [PULL 11/13] qapi/parser: enable mypy checks, Markus Armbruster, 2021/10/02
- [PULL 12/13] qapi/parser: Silence too-few-public-methods warning, Markus Armbruster, 2021/10/02
- [PULL 01/13] qapi/pylintrc: ignore 'consider-using-f-string' warning, Markus Armbruster, 2021/10/02
- [PULL 04/13] qapi: Add spaces after symbol declaration for consistency, Markus Armbruster, 2021/10/02
- [PULL 09/13] qapi/parser: add type hint annotations (QAPIDoc), Markus Armbruster, 2021/10/02
- [PULL 06/13] qapi/parser: clarify _end_section() logic, Markus Armbruster, 2021/10/02
- [PULL 13/13] qapi/parser: enable pylint checks, Markus Armbruster, 2021/10/02
- [PULL 05/13] qapi/parser: remove FIXME comment from _append_body_line, Markus Armbruster, 2021/10/02
- [PULL 03/13] qapi/parser: fix unused check_args_section arguments, Markus Armbruster, 2021/10/02
- [PULL 10/13] qapi/parser: Add FIXME for consolidating JSON-related types,
Markus Armbruster <=
- [PULL 08/13] qapi/parser: add import cycle workaround, Markus Armbruster, 2021/10/02
- Re: [PULL 00/13] QAPI patches patches for 2021-10-02, Richard Henderson, 2021/10/02