Re: [PATCH] target/mips: remove gen_mfc0_load64() and use tcg_gen_ld32s_tl()

[Richard Henderson]

On 10/2/21 9:37 AM, Philippe Mathieu-Daudé wrote:
> From: Leon Alrae<leon.alrae@imgtec.com>
>
> Remove misleading gen_mfc0_load64() which actually loads 32 or 64 bits
> depending whether MIPS32 or MIPS64 and also replace the pair of
> tcg_gen_ld_tl() + tcg_gen_ext32s_tl() with single tcg_gen_ld32s_tl().
>
> Patch partly generated using the following spatch script:
>
>      @@
>      expression reg, env, ofs;
>      @@
>      -tcg_gen_ld_tl(reg, env, ofs);
>      -tcg_gen_ext32s_tl(reg, reg);
>      +tcg_gen_ld32s_tl(reg, env, ofs);
>
> Signed-off-by: Leon Alrae<leon.alrae@imgtec.com>
> [PMD: Rebased and used Coccinelle spatch to complete]
> Signed-off-by: Philippe Mathieu-Daudé<f4bug@amsat.org>
> ---
>   target/mips/tcg/translate.c | 68 ++++++++++++++++---------------------
>   1 file changed, 29 insertions(+), 39 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~