[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 2/5] hw/arm/virt: Add a control for the the highmem redist
|
From: |
Andrew Jones |
|
Subject: |
Re: [PATCH v2 2/5] hw/arm/virt: Add a control for the the highmem redistributors |
|
Date: |
Mon, 4 Oct 2021 12:14:03 +0200 |
On Mon, Oct 04, 2021 at 11:44:08AM +0200, Andrew Jones wrote:
> On Sun, Oct 03, 2021 at 05:46:02PM +0100, Marc Zyngier wrote:
...
> >
> > - return MACHINE(vms)->smp.cpus > redist0_capacity ? 2 : 1;
> > + return (MACHINE(vms)->smp.cpus > redist0_capacity &&
> > + vms->highmem_redists) ? 2 : 1;
>
> Wouldn't it be equivalent to just use vms->highmem here?
OK, I see in the last patch that we may disable highmem_redists
but not highmem.
In that case,
Reviewed-by: Andrew Jones <drjones@redhat.com>
Thanks,
drew
- [PATCH v2 4/5] hw/arm/virt: Use the PA range to compute the memory map, (continued)