[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v1 1/7] hw/misc/bcm2835_property: Add FIXME comment for uninitial
From: |
Alex Bennée |
Subject: |
[PATCH v1 1/7] hw/misc/bcm2835_property: Add FIXME comment for uninitialized memory |
Date: |
Mon, 4 Oct 2021 14:47:35 +0100 |
From: Philippe Mathieu-Daudé <f4bug@amsat.org>
We are returning unintialized memory, this is probably unsafe.
Reported-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
hw/misc/bcm2835_property.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/misc/bcm2835_property.c b/hw/misc/bcm2835_property.c
index 73941bdae9..791c7554ec 100644
--- a/hw/misc/bcm2835_property.c
+++ b/hw/misc/bcm2835_property.c
@@ -61,6 +61,7 @@ static void bcm2835_property_mbox_push(BCM2835PropertyState
*s, uint32_t value)
qemu_log_mask(LOG_UNIMP,
"bcm2835_property: 0x%08x get board model NYI\n",
tag);
+ /* FIXME returning uninitialized memory */
resplen = 4;
break;
case 0x00010002: /* Get board revision */
@@ -75,6 +76,7 @@ static void bcm2835_property_mbox_push(BCM2835PropertyState
*s, uint32_t value)
qemu_log_mask(LOG_UNIMP,
"bcm2835_property: 0x%08x get board serial NYI\n",
tag);
+ /* FIXME returning uninitialized memory */
resplen = 8;
break;
case 0x00010005: /* Get ARM memory */
--
2.30.2
- [PATCH v1 0/7] enabling RasperryPi 4 emulation - WIP state, Alex Bennée, 2021/10/04
- [PATCH v1 2/7] hw/misc/bcm2835_property: Handle the 'domain state' property, Alex Bennée, 2021/10/04
- [PATCH v1 4/7] hw/arm/bcm2835_peripherals: Map various BCM2711 blocks, Alex Bennée, 2021/10/04
- [PATCH v1 7/7] hw/arm/raspi: Add the Raspberry Pi 4B board, Alex Bennée, 2021/10/04
- [PATCH v1 1/7] hw/misc/bcm2835_property: Add FIXME comment for uninitialized memory,
Alex Bennée <=
- [PATCH v1 3/7] hw/arm: fix the position of vcram for raspi, Alex Bennée, 2021/10/04
- [PATCH v1 6/7] hw/arm/bcm2838: Map the PCIe memory space, Alex Bennée, 2021/10/04
- [PATCH v1 5/7] hw/arm/bcm2836: Add the BCM2711 which uses a GICv2, Alex Bennée, 2021/10/04