Re: [RFC PATCH] .github: move repo lockdown to the v2 configuration

[Willian Rampazzo]

On Mon, Oct 4, 2021 at 12:45 PM Alex Bennée <alex.bennee@linaro.org> wrote:
>
> I was getting prompted by GitHub for new permissions but it turns out
> per https://github.com/dessant/repo-lockdown/issues/6:
>
>   Repo Lockdown has been rewritten for GitHub Actions, offering new
>   features and better control over your automation presets. The legacy
>   GitHub App has been deprecated, and the public instance of the app
>   has been shut down.
>
> So this is what I've done.
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
>  .github/lockdown.yml           | 34 ------------------------
>  .github/workflows/lockdown.yml | 47 ++++++++++++++++++++++++++++++++++
>  2 files changed, 47 insertions(+), 34 deletions(-)
>  delete mode 100644 .github/lockdown.yml
>  create mode 100644 .github/workflows/lockdown.yml
>
> diff --git a/.github/lockdown.yml b/.github/lockdown.yml
> deleted file mode 100644
> index d3546bd2bc..0000000000
> --- a/.github/lockdown.yml
> +++ /dev/null
> @@ -1,34 +0,0 @@
> -# Configuration for Repo Lockdown - https://github.com/dessant/repo-lockdown
> -
> -# Close issues and pull requests
> -close: true
> -
> -# Lock issues and pull requests
> -lock: true
> -
> -issues:
> -  comment: |
> -    Thank you for your interest in the QEMU project.
> -
> -    This repository is a read-only mirror of the project's repostories hosted
> -    at https://gitlab.com/qemu-project/qemu.git.
> -    The project does not process issues filed on GitHub.
> -
> -    The project issues are tracked on GitLab:
> -    https://gitlab.com/qemu-project/qemu/-/issues
> -
> -    QEMU welcomes bug report contributions. You can file new ones on:
> -    https://gitlab.com/qemu-project/qemu/-/issues/new
> -
> -pulls:
> -  comment: |
> -    Thank you for your interest in the QEMU project.
> -
> -    This repository is a read-only mirror of the project's repostories hosted
> -    on https://gitlab.com/qemu-project/qemu.git.
> -    The project does not process merge requests filed on GitHub.
> -
> -    QEMU welcomes contributions of code (either fixing bugs or adding new
> -    functionality). However, we get a lot of patches, and so we have some
> -    guidelines about contributing on the project website:
> -    https://www.qemu.org/contribute/
> diff --git a/.github/workflows/lockdown.yml b/.github/workflows/lockdown.yml
> new file mode 100644
> index 0000000000..20e6208487
> --- /dev/null
> +++ b/.github/workflows/lockdown.yml
> @@ -0,0 +1,47 @@
> +# Configuration for Repo Lockdown - https://github.com/dessant/repo-lockdown
> +
> +name: 'Repo Lockdown'
> +
> +on:
> +  issues:
> +    types: opened

I see the "issues" tab is already disabled on the QEMU repository at
GitHub. Maybe we don't need an action for that.

> +  pull_request_target:
> +    types: opened
> +
> +permissions:
> +  issues: write
> +  pull-requests: write
> +
> +jobs:
> +  action:
> +    runs-on: ubuntu-latest
> +    steps:
> +      - uses: dessant/repo-lockdown@v2
> +        with:
> +          issue-comment: |
> +            Thank you for your interest in the QEMU project.
> +
> +            This repository is a read-only mirror of the project's 
> repostories hosted
> +            at https://gitlab.com/qemu-project/qemu.git.
> +            The project does not process issues filed on GitHub.
> +
> +            The project issues are tracked on GitLab:
> +            https://gitlab.com/qemu-project/qemu/-/issues
> +
> +            QEMU welcomes bug report contributions. You can file new ones on:
> +            https://gitlab.com/qemu-project/qemu/-/issues/new
> +          lock-issue: true
> +          close-issue: true
> +          pull-comment: |
> +            Thank you for your interest in the QEMU project.
> +
> +            This repository is a read-only mirror of the project's 
> repostories hosted
> +            on https://gitlab.com/qemu-project/qemu.git.
> +            The project does not process merge requests filed on GitHub.
> +
> +            QEMU welcomes contributions of code (either fixing bugs or 
> adding new
> +            functionality). However, we get a lot of patches, and so we have 
> some
> +            guidelines about contributing on the project website:
> +            https://www.qemu.org/contribute/
> +          lock-pull: true
> +          close-pull: true
> --
> 2.30.2
>
>

Besides the "issues" comment, it looks good to me.

Reviewed-by: Willian Rampazzo <willianr@redhat.com>