[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 07/13] iotests/297: Split run_linters apart into run_pylint and r
From: |
John Snow |
Subject: |
[PATCH 07/13] iotests/297: Split run_linters apart into run_pylint and run_mypy |
Date: |
Mon, 4 Oct 2021 17:04:57 -0400 |
Signed-off-by: John Snow <jsnow@redhat.com>
---
Note, this patch really ought to be squashed with the next one, but I am
performing a move known as "Hedging my bets."
It's easier to squash than de-squash :)
Signed-off-by: John Snow <jsnow@redhat.com>
---
tests/qemu-iotests/297 | 19 ++++++++++++-------
1 file changed, 12 insertions(+), 7 deletions(-)
diff --git a/tests/qemu-iotests/297 b/tests/qemu-iotests/297
index fcbab0631be..91029dbb34e 100755
--- a/tests/qemu-iotests/297
+++ b/tests/qemu-iotests/297
@@ -61,20 +61,19 @@ def get_test_files() -> List[str]:
return list(filter(is_python_file, check_tests))
-def run_linters(
+def run_pylint(
files: List[str],
env: Optional[Mapping[str, str]] = None,
) -> None:
- print('=== pylint ===')
- sys.stdout.flush()
-
subprocess.run(('python3', '-m', 'pylint', *files),
env=env, check=False)
- print('=== mypy ===')
- sys.stdout.flush()
+def run_mypy(
+ files: List[str],
+ env: Optional[Mapping[str, str]] = None,
+) -> None:
p = subprocess.run((('python3', '-m', 'mypy', *files),
env=env,
check=False,
@@ -99,7 +98,13 @@ def main() -> None:
env = os.environ.copy()
env['MYPYPATH'] = env['PYTHONPATH']
- run_linters(files, env=env)
+ print('=== pylint ===')
+ sys.stdout.flush()
+ run_pylint(files, env=env)
+
+ print('=== mypy ===')
+ sys.stdout.flush()
+ run_mypy(files, env=env)
iotests.script_main(main)
--
2.31.1
- [PATCH 02/13] iotests/297: Split mypy configuration out into mypy.ini, (continued)
- [PATCH 02/13] iotests/297: Split mypy configuration out into mypy.ini, John Snow, 2021/10/04
- [PATCH 01/13] iotests/297: Move pylint config into pylintrc, John Snow, 2021/10/04
- [PATCH 03/13] iotests/297: Add get_files() function, John Snow, 2021/10/04
- [PATCH 05/13] iotests/297: Create main() function, John Snow, 2021/10/04
- [PATCH 07/13] iotests/297: Split run_linters apart into run_pylint and run_mypy,
John Snow <=
- [PATCH 06/13] iotests/297: Separate environment setup from test execution, John Snow, 2021/10/04
- [PATCH 04/13] iotests/297: Don't rely on distro-specific linter binaries, John Snow, 2021/10/04
- [PATCH 10/13] iotests/linters: Add entry point for linting via Python CI, John Snow, 2021/10/04
- [PATCH 08/13] iotests/297: refactor run_[mypy|pylint] as generic execution shim, John Snow, 2021/10/04
- [PATCH 09/13] iotests: split linters.py out from 297, John Snow, 2021/10/04