|
From: | Cédric Le Goater |
Subject: | Re: [PATCH] target/ppc: Fix test the decrementer exception |
Date: | Tue, 5 Oct 2021 07:26:25 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 |
in Subject: s/test// On 10/4/21 23:45, BALATON Zoltan wrote:
On Mon, 4 Oct 2021, Cédric Le Goater wrote:Commit 4d9b8ef9b5ab ("target/ppc: Fix 64-bit decrementer") introduced new int64t variables and broke the test triggering the decrementer exception. Revert partially the change to evaluate both clause of the if statement. Fixes: Coverity CID 1464061Shouldn't this be: Reported-by: Coverity CID 1464061 Fixes: 4d9b8ef9b5ab ("target/ppc: Fix 64-bit decrementer") or something similar?
I went through the commit logs before sending and that seemed to be the latest practice. Not an issue. I can resend. C.
Regards, BALATON ZoltanSigned-off-by: Cédric Le Goater <clg@kaod.org> --- hw/ppc/ppc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ppc/ppc.c b/hw/ppc/ppc.c index f5d012f860af..a724b0bb5ecb 100644 --- a/hw/ppc/ppc.c +++ b/hw/ppc/ppc.c @@ -848,7 +848,7 @@ static void __cpu_ppc_store_decr(PowerPCCPU *cpu, uint64_t *nextp, * On MSB edge based DEC implementations the MSB going from 0 -> 1 triggers * an edge interrupt, so raise it here too. */ - if ((signed_value < 3) || + if ((value < 3) || ((tb_env->flags & PPC_DECR_UNDERFLOW_LEVEL) && signed_value < 0) || ((tb_env->flags & PPC_DECR_UNDERFLOW_TRIGGERED) && signed_value < 0 && signed_decr >= 0)) {
[Prev in Thread] | Current Thread | [Next in Thread] |