[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 03/12] macfb: fix overflow of color_palette array
From: |
Laurent Vivier |
Subject: |
Re: [PATCH v2 03/12] macfb: fix overflow of color_palette array |
Date: |
Tue, 5 Oct 2021 08:34:03 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 |
Le 04/10/2021 à 23:19, Mark Cave-Ayland a écrit :
> The palette_current index counter has a maximum size of 256 * 3 to cover a
> full
> color palette of 256 RGB entries. Linux assumes that the palette_current index
> wraps back around to zero after writing 256 RGB entries so ensure that
> palette_current is reset at this point to prevent data corruption within
> MacfbState.
>
> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> ---
> hw/display/macfb.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/hw/display/macfb.c b/hw/display/macfb.c
> index b363bab889..39dab49026 100644
> --- a/hw/display/macfb.c
> +++ b/hw/display/macfb.c
> @@ -303,7 +303,9 @@ static void macfb_ctrl_write(void *opaque,
> s->palette_current = 0;
> break;
> case DAFB_LUT:
> - s->color_palette[s->palette_current++] = val;
> + s->color_palette[s->palette_current] = val;
> + s->palette_current = (s->palette_current + 1) %
> + ARRAY_SIZE(s->color_palette);
> if (s->palette_current % 3) {
> macfb_invalidate_display(s);
> }
>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
- [PATCH v2 00/12] macfb: fixes for booting MacOS, Mark Cave-Ayland, 2021/10/04
- [PATCH v2 01/12] macfb: handle errors that occur during realize, Mark Cave-Ayland, 2021/10/04
- [PATCH v2 02/12] macfb: fix invalid object reference in macfb_common_realize(), Mark Cave-Ayland, 2021/10/04
- [PATCH v2 03/12] macfb: fix overflow of color_palette array, Mark Cave-Ayland, 2021/10/04
- Re: [PATCH v2 03/12] macfb: fix overflow of color_palette array,
Laurent Vivier <=
- [PATCH v2 04/12] macfb: use memory_region_init_ram() in macfb_common_realize() for the framebuffer, Mark Cave-Ayland, 2021/10/04
- [PATCH v2 05/12] macfb: add trace events for reading and writing the control registers, Mark Cave-Ayland, 2021/10/04
- [PATCH v2 06/12] macfb: implement mode sense to allow display type to be detected, Mark Cave-Ayland, 2021/10/04
- [PATCH v2 07/12] macfb: add qdev property to specify display type, Mark Cave-Ayland, 2021/10/04
- [PATCH v2 10/12] macfb: fix 24-bit RGB pixel encoding, Mark Cave-Ayland, 2021/10/04
- [PATCH v2 08/12] macfb: add common monitor modes supported by the MacOS toolbox ROM, Mark Cave-Ayland, 2021/10/04