qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 1/2] hw/adc: Add basic Aspeed ADC model


From: Cédric Le Goater
Subject: Re: [PATCH v2 1/2] hw/adc: Add basic Aspeed ADC model
Date: Tue, 5 Oct 2021 09:33:25 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0

On 10/5/21 07:31, Peter Delevoryas wrote:


On Oct 4, 2021, at 12:49 AM, Cédric Le Goater <clg@kaod.org> wrote:

On 10/3/21 21:18, pdel@fb.com wrote:
From: Andrew Jeffery <andrew@aj.id.au>
This model implements enough behaviour to do basic functionality tests
such as device initialisation and read out of dummy sample values. The
sample value generation strategy is similar to the STM ADC already in
the tree.
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
[clg : support for multiple engines (AST2600) ]
Signed-off-by: Cédric Le Goater <clg@kaod.org>
[pdel : refactored engine register struct fields to regs[] array field]
[pdel : added guest-error checking for upper-8 channel regs in AST2600]
Signed-off-by: Peter Delevoryas <pdel@fb.com>

Reviewed-by: Cédric Le Goater <clg@kaod.org>

Thanks,

C.

Hey Cedric,

Actually, I have just submitted a v3 of this patch series to support 16-bit
reads of the channel data registers. I don’t think I tested using the driver
to read from the ADC, and that’s what Patrick found crashed with these
changes. Since it’s relatively easy to enable 16-bit reads, I figured
I would just include that.

OK.

A Tested-by: tag would be welcome !

Thanks,

C.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]