[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] gitlab: Escape git-describe match pattern on Windows hosts
From: |
Daniel P . Berrangé |
Subject: |
Re: [PATCH] gitlab: Escape git-describe match pattern on Windows hosts |
Date: |
Tue, 5 Oct 2021 09:43:51 +0100 |
User-agent: |
Mutt/2.0.7 (2021-05-04) |
On Tue, Oct 05, 2021 at 10:40:00AM +0200, Cédric Le Goater wrote:
> > I'm curious if you go to
> >
> > https://gitlab.com/legoater/qemu/-/settings/ci_cd
> >
> > and expand "General pipelines", what value is set for the
> >
> > "Git shallow clone"
> >
> > setting. In my fork it is 0 which means unlimited depth, but in
> > gitlab docs I see reference to repos getting this set to 50
> > since a particular gitlab release.
>
> Sorry for the late reply.
>
> Setting the value to 0 fixed the windows build on gitlab.
Ok, so we've got two options
- Change the code so it has sane fallback if the tags are all missing
- Set GIT_DEPTH in the affected jobs to a value that is larger than
the maximum number of commits we expect in the course of a single
dev cycle, plus 20% grace on top, so that we're guaranteed enough
history to describe one tag.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|