[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 05/11] hw/arm/virt: Use object_property_set instead of qde
From: |
Eric Auger |
Subject: |
Re: [PATCH v4 05/11] hw/arm/virt: Use object_property_set instead of qdev_prop_set |
Date: |
Tue, 5 Oct 2021 11:27:52 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 |
On 10/1/21 7:33 PM, Jean-Philippe Brucker wrote:
> To propagate errors to the caller of the pre_plug callback, use the
> object_poperty_set*() functions directly instead of the qdev_prop_set*()
> helpers.
>
> Suggested-by: Igor Mammedov <imammedo@redhat.com>
> Signed-off-by: Jean-Philippe Brucker <jean-philippe@linaro.org>
Reviewed-by: Eric Auger <eric.auger@redhat.com>
Eric
> ---
> hw/arm/virt.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/hw/arm/virt.c b/hw/arm/virt.c
> index 36f0261ef4..ac307b6030 100644
> --- a/hw/arm/virt.c
> +++ b/hw/arm/virt.c
> @@ -2465,8 +2465,9 @@ static void
> virt_machine_device_pre_plug_cb(HotplugHandler *hotplug_dev,
> db_start, db_end,
> VIRTIO_IOMMU_RESV_MEM_T_MSI);
>
> - qdev_prop_set_uint32(dev, "len-reserved-regions", 1);
> - qdev_prop_set_string(dev, "reserved-regions[0]", resv_prop_str);
> + object_property_set_uint(OBJECT(dev), "len-reserved-regions", 1,
> errp);
> + object_property_set_str(OBJECT(dev), "reserved-regions[0]",
> + resv_prop_str, errp);
> g_free(resv_prop_str);
> }
> }
- [PATCH v4 00/11] virtio-iommu: Add ACPI support, Jean-Philippe Brucker, 2021/10/01
- [PATCH v4 05/11] hw/arm/virt: Use object_property_set instead of qdev_prop_set, Jean-Philippe Brucker, 2021/10/01
- [PATCH v4 04/11] hw/arm/virt: Reject instantiation of multiple IOMMUs, Jean-Philippe Brucker, 2021/10/01
- [PATCH v4 06/11] hw/i386: Move vIOMMU uniqueness check into pc.c, Jean-Philippe Brucker, 2021/10/01
- [PATCH v4 01/11] hw/acpi: Add VIOT table, Jean-Philippe Brucker, 2021/10/01
- [PATCH v4 09/11] tests/acpi: add test cases for VIOT, Jean-Philippe Brucker, 2021/10/01