[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH 1/1] virtio: write back features before verify
From: |
Halil Pasic |
Subject: |
Re: [RFC PATCH 1/1] virtio: write back features before verify |
Date: |
Tue, 5 Oct 2021 12:46:34 +0200 |
On Tue, 5 Oct 2021 03:53:17 -0400
"Michael S. Tsirkin" <mst@redhat.com> wrote:
> > Wouldn't a call from transport code into virtio core
> > be more handy? What I have in mind is stuff like vhost-user and vdpa. My
> > understanding is, that for vhost setups where the config is outside qemu,
> > we probably need a new command that tells the vhost backend what
> > endiannes to use for config. I don't think we can use
> > VHOST_USER_SET_VRING_ENDIAN because that one is on a virtqueue basis
> > according to the doc. So for vhost-user and similar we would fire that
> > command and probably also set the filed, while for devices for which
> > control plane is handled by QEMU we would just set the field.
> >
> > Does that sound about right?
>
> I'm fine either way, but when would you invoke this?
> With my idea backends can check the field when get_config
> is invoked.
>
> As for using this in VHOST, can we maybe re-use SET_FEATURES?
>
> Kind of hacky but nice in that it will actually make existing backends
> work...
Basically the equivalent of this patch, just on the vhost interface,
right? Could work I have to look into it :)
- Re: [RFC PATCH 1/1] virtio: write back features before verify, (continued)
- Re: [RFC PATCH 1/1] virtio: write back features before verify, Cornelia Huck, 2021/10/04
- Re: [RFC PATCH 1/1] virtio: write back features before verify, Michael S. Tsirkin, 2021/10/04
- Re: [RFC PATCH 1/1] virtio: write back features before verify, Cornelia Huck, 2021/10/04
- Re: [RFC PATCH 1/1] virtio: write back features before verify, Michael S. Tsirkin, 2021/10/04
- Re: [RFC PATCH 1/1] virtio: write back features before verify, Cornelia Huck, 2021/10/04
- Re: [RFC PATCH 1/1] virtio: write back features before verify, Michael S. Tsirkin, 2021/10/04
- Re: [RFC PATCH 1/1] virtio: write back features before verify, Cornelia Huck, 2021/10/06
- Re: [RFC PATCH 1/1] virtio: write back features before verify, Michael S. Tsirkin, 2021/10/06
- Re: [RFC PATCH 1/1] virtio: write back features before verify, Halil Pasic, 2021/10/05
- Re: [RFC PATCH 1/1] virtio: write back features before verify, Michael S. Tsirkin, 2021/10/05
- Re: [RFC PATCH 1/1] virtio: write back features before verify,
Halil Pasic <=
- Re: [RFC PATCH 1/1] virtio: write back features before verify, Michael S. Tsirkin, 2021/10/05