Re: [PATCH v3 0/3] hw/arm/virt_acpi_build: Generate DBG2 table

[Michael S. Tsirkin]

On Mon, Sep 27, 2021 at 03:17:29PM +0200, Eric Auger wrote:
> This series generates the ACPI DBG2 table along with machvirt.
> It applies on top of Igor's
> [PATCH v4 00/35] acpi: refactor error prone build_header() and
> packed structures usage in ACPI tables
> 
> The DBG2 specification can be found at
> https://docs.microsoft.com/en-us/windows-hardware/drivers/bringup/acpi-debug-port-table.
> 
> DBG2 is mandated by ARM SBBR since its v1.0 release (the rationale
> behind is Windows requires it on all systems).
> 
> The DBG2 is used to describe a debug port, used by the kernel debugger.
> 
> This series and its dependency can be found at
> https://github.com/eauger/qemu.git
> branch: igor_acpi_refactoring_v4_dbg2_v3


Acked-by: Michael S. Tsirkin <mst@redhat.com>


> History:
> v2 -> v3:
> - addressed all comments from Igor on v2:
>   patches 2/3 swapped
>   style adjustments in "hw/arm/virt_acpi_build: Generate DBG2 table"
>   + more precision on spec references
> 
> v1 -> v2:
> - rebase on top of Igor's series and use acpi_init_table/acpi_table_composed
>   and build_append_int_noprefix()
> 
> 
> Eric Auger (3):
>   tests/acpi: Add void table for virt/DBG2 bios-tables-test
>   hw/arm/virt_acpi_build: Generate DBG2 table
>   bios-tables-test: Generate reference table for virt/DBG2
> 
>  hw/arm/virt-acpi-build.c  |  62 +++++++++++++++++++++++++++++++++++++-
>  tests/data/acpi/virt/DBG2 | Bin 0 -> 87 bytes
>  2 files changed, 61 insertions(+), 1 deletion(-)
>  create mode 100644 tests/data/acpi/virt/DBG2
> 
> -- 
> 2.26.3