[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 07/12] migration: add missing qemu_mutex_lock_iothread in migratio
From: |
Paolo Bonzini |
Subject: |
[PULL 07/12] migration: add missing qemu_mutex_lock_iothread in migration_completion |
Date: |
Tue, 5 Oct 2021 18:44:03 +0200 |
From: Emanuele Giuseppe Esposito <eesposit@redhat.com>
qemu_savevm_state_complete_postcopy assumes the iothread lock (BQL)
to be held, but instead it isn't.
Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Message-Id: <20211005080751.3797161-3-eesposit@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
migration/migration.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/migration/migration.c b/migration/migration.c
index bb909781b7..6ac807ef3d 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -3168,7 +3168,10 @@ static void migration_completion(MigrationState *s)
} else if (s->state == MIGRATION_STATUS_POSTCOPY_ACTIVE) {
trace_migration_completion_postcopy_end();
+ qemu_mutex_lock_iothread();
qemu_savevm_state_complete_postcopy(s->to_dst_file);
+ qemu_mutex_unlock_iothread();
+
trace_migration_completion_postcopy_end_after_complete();
} else if (s->state == MIGRATION_STATUS_CANCELLING) {
goto fail;
--
2.31.1
- [PULL 00/12] Misc changes for 2021-10-05, Paolo Bonzini, 2021/10/05
- [PULL 02/12] sev/i386: Introduce sev_add_kernel_loader_hashes for measured linux boot, Paolo Bonzini, 2021/10/05
- [PULL 04/12] hw/misc: applesmc: use host osk as default on macs, Paolo Bonzini, 2021/10/05
- [PULL 07/12] migration: add missing qemu_mutex_lock_iothread in migration_completion,
Paolo Bonzini <=
- [PULL 01/12] i386: docs: Briefly describe KVM PV features, Paolo Bonzini, 2021/10/05
- [PULL 03/12] x86/sev: generate SEV kernel loader hashes in x86_load_linux, Paolo Bonzini, 2021/10/05
- [PULL 05/12] configure, meson: move CPU_CFLAGS out of QEMU_CFLAGS, Paolo Bonzini, 2021/10/05
- [PULL 08/12] meson: bump submodule to 0.59.2, Paolo Bonzini, 2021/10/05
- [PULL 11/12] target/xtensa: list cores in a text file, Paolo Bonzini, 2021/10/05
- [PULL 10/12] hexagon: use env keyword argument to pass PYTHONPATH, Paolo Bonzini, 2021/10/05
- [PULL 09/12] meson: switch minimum meson version to 0.58.2, minimum recommended to 0.59.2, Paolo Bonzini, 2021/10/05
- [PULL 12/12] meson: show library versions in the summary, Paolo Bonzini, 2021/10/05