|
From: | Paolo Bonzini |
Subject: | Re: [PATCH 1/2] bsd-user: Only process meson rules on BSD host |
Date: | Tue, 5 Oct 2021 21:16:18 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 |
On 27/09/21 07:24, Philippe Mathieu-Daudé wrote:
Why here and not in the parent meson.build?This is what Paolo recommended me to do last time I added a conditional inclusion. Personally I prefer having it in the call site rather than the callee (no need to read the callee to notice it isn't called). I guess this is for readability, to not clutter meson.build? files more...
Yes, pretty much. In this case it's quite obvious that bsd-user is BSD-only, but I prefer it if dir/meson.build has the knowledge of what goes on in dir/.
That said, we're not terribly consistent, see have_block and have_tools, so either will be okay.
Paolo
Paolo, what is your preference?
[Prev in Thread] | Current Thread | [Next in Thread] |