qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 15/17] python/aqmp: Create sync QMP wrapper for iotests


From: John Snow
Subject: Re: [PATCH v2 15/17] python/aqmp: Create sync QMP wrapper for iotests
Date: Wed, 6 Oct 2021 11:12:04 -0400



On Wed, Oct 6, 2021 at 10:32 AM Paolo Bonzini <pbonzini@redhat.com> wrote:
On 06/10/21 16:24, John Snow wrote:
>
> I had plans at one point to make a sync.py, but with an interface that
> matched async QMP itself more closely. I spent some time trying to
> research how to make a "magic" sync wrapper around async QMP, and hit a
> few trouble spots. I've still got the patch, but I felt some pressure to
> try and switch iotests over as fast as possible to get more
> trial-by-fire time this release cycle. I named them "sync.py" and
> "legacy.py" in my branch accordingly. Of course, I made a beeline
> straight for the iotests version, so now it looks odd. I may yet try to
> clean up the other version, possibly converting legacy.py to work in
> terms of sync.py, and then converting users in iotests so that I can
> drop legacy.py.

Got it.  So maybe aqmp.qmp_next or aqmp.qmp_experimental?  What I mean
is, it's all but legacy. :)


Mmm, yeah I guess I meant "legacy interface" and not "legacy implementation" ;)

I could do 'compat.py' for the iotests-compatible interface and 'sync.py' for the "modern" one?

--js

reply via email to

[Prev in Thread] Current Thread [Next in Thread]