[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 09/23] target/i386/sev: Remove sev_get_me_mask()
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH v4 09/23] target/i386/sev: Remove sev_get_me_mask() |
Date: |
Thu, 7 Oct 2021 18:17:02 +0200 |
Unused dead code makes review harder, so remove it.
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: Connor Kuehl <ckuehl@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
target/i386/sev_i386.h | 1 -
target/i386/sev-stub.c | 5 -----
target/i386/sev.c | 9 ---------
3 files changed, 15 deletions(-)
diff --git a/target/i386/sev_i386.h b/target/i386/sev_i386.h
index 9bf6cd18789..d83428fa265 100644
--- a/target/i386/sev_i386.h
+++ b/target/i386/sev_i386.h
@@ -36,7 +36,6 @@ typedef struct SevKernelLoaderContext {
} SevKernelLoaderContext;
extern bool sev_es_enabled(void);
-extern uint64_t sev_get_me_mask(void);
extern SevInfo *sev_get_info(void);
extern uint32_t sev_get_cbit_position(void);
extern uint32_t sev_get_reduced_phys_bits(void);
diff --git a/target/i386/sev-stub.c b/target/i386/sev-stub.c
index 408441768dc..20b1e18ec1b 100644
--- a/target/i386/sev-stub.c
+++ b/target/i386/sev-stub.c
@@ -25,11 +25,6 @@ bool sev_enabled(void)
return false;
}
-uint64_t sev_get_me_mask(void)
-{
- return ~0;
-}
-
uint32_t sev_get_cbit_position(void)
{
return 0;
diff --git a/target/i386/sev.c b/target/i386/sev.c
index 4f1952cd32f..9e3f2ec8dd3 100644
--- a/target/i386/sev.c
+++ b/target/i386/sev.c
@@ -65,7 +65,6 @@ struct SevGuestState {
uint8_t api_major;
uint8_t api_minor;
uint8_t build_id;
- uint64_t me_mask;
int sev_fd;
SevState state;
gchar *measurement;
@@ -389,12 +388,6 @@ sev_es_enabled(void)
return sev_enabled() && (sev_guest->policy & SEV_POLICY_ES);
}
-uint64_t
-sev_get_me_mask(void)
-{
- return sev_guest ? sev_guest->me_mask : ~0;
-}
-
uint32_t
sev_get_cbit_position(void)
{
@@ -833,8 +826,6 @@ int sev_kvm_init(ConfidentialGuestSupport *cgs, Error
**errp)
goto err;
}
- sev->me_mask = ~(1UL << sev->cbitpos);
-
devname = object_property_get_str(OBJECT(sev), "sev-device", NULL);
sev->sev_fd = open(devname, O_RDWR);
if (sev->sev_fd < 0) {
--
2.31.1
- [PATCH v4 00/23] target/i386/sev: Housekeeping SEV + measured Linux SEV guest, Philippe Mathieu-Daudé, 2021/10/07
- [PATCH v4 01/23] qapi/misc-target: Wrap long 'SEV Attestation Report' long lines, Philippe Mathieu-Daudé, 2021/10/07
- [PATCH v4 03/23] target/i386/kvm: Introduce i386_softmmu_kvm Meson source set, Philippe Mathieu-Daudé, 2021/10/07
- [PATCH v4 02/23] qapi/misc-target: Group SEV QAPI definitions, Philippe Mathieu-Daudé, 2021/10/07
- [PATCH v4 04/23] target/i386/kvm: Restrict SEV stubs to x86 architecture, Philippe Mathieu-Daudé, 2021/10/07
- [PATCH v4 05/23] target/i386/sev: Prefix QMP errors with 'SEV', Philippe Mathieu-Daudé, 2021/10/07
- [PATCH v4 06/23] target/i386/monitor: Return QMP error when SEV is not enabled for guest, Philippe Mathieu-Daudé, 2021/10/07
- [PATCH v4 07/23] target/i386/cpu: Add missing 'qapi/error.h' header, Philippe Mathieu-Daudé, 2021/10/07
- [PATCH v4 08/23] target/i386/sev_i386.h: Remove unused headers, Philippe Mathieu-Daudé, 2021/10/07
- [PATCH v4 09/23] target/i386/sev: Remove sev_get_me_mask(),
Philippe Mathieu-Daudé <=
- [PATCH v4 10/23] target/i386/sev: Mark unreachable code with g_assert_not_reached(), Philippe Mathieu-Daudé, 2021/10/07
- [PATCH v4 11/23] target/i386/sev: sev_get_attestation_report use g_autofree, Philippe Mathieu-Daudé, 2021/10/07
- [PATCH v4 12/23] target/i386/sev: Use g_autofree in sev_launch_get_measure(), Philippe Mathieu-Daudé, 2021/10/07
- [PATCH v4 13/23] target/i386/sev: Restrict SEV to system emulation, Philippe Mathieu-Daudé, 2021/10/07
- [PATCH v4 14/23] target/i386/sev: Rename sev_i386.h -> sev.h, Philippe Mathieu-Daudé, 2021/10/07
- [PATCH v4 15/23] target/i386/sev: Declare system-specific functions in 'sev.h', Philippe Mathieu-Daudé, 2021/10/07
- [PATCH v4 16/23] target/i386/sev: Remove stubs by using code elision, Philippe Mathieu-Daudé, 2021/10/07