qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC PATCH v2 17/25] include/block/transactions: global state API +


From: Emanuele Giuseppe Esposito
Subject: Re: [RFC PATCH v2 17/25] include/block/transactions: global state API + assertions
Date: Fri, 8 Oct 2021 09:18:56 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1



On 07/10/2021 16:47, Stefan Hajnoczi wrote:
On Tue, Oct 05, 2021 at 10:32:07AM -0400, Emanuele Giuseppe Esposito wrote:
transactions run always under the BQL lock, so they are all
in the global state API.

Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
---
  include/qemu/transactions.h | 24 ++++++++++++++++++++++++
  util/transactions.c         |  4 ++++
  2 files changed, 28 insertions(+)

Hmm...not sure about this. Maybe Vladimir can share his thoughts.

This seems like a library that can be used in various situations. It has
no connection to the BQL. There's no need to declare it GS or I/O
because it's just a utility just like QEMUIOVector, etc.


Ok, I can remove this patch for next version, and then we can discuss whether to add it or not.

Thank you,
Emanuele




reply via email to

[Prev in Thread] Current Thread [Next in Thread]