On 07/10/21 21:24, Richard Henderson wrote:
> On 10/7/21 6:08 AM, Paolo Bonzini wrote:
>> +++ b/stubs/meson.build
>> @@ -20,7 +20,9 @@ endif
>> stub_ss.add(files('iothread-lock.c'))
>> stub_ss.add(files('isa-bus.c'))
>> stub_ss.add(files('is-daemonized.c'))
>> -stub_ss.add(when: 'CONFIG_LINUX_AIO', if_true: files('linux-aio.c'))
>> +if libaio.found()
>> + stub_ss.add(if_true: files('linux-aio.c'))
>> +endif
>
> This bit doesn't look quite right, with the if_true.
It looks silly but it works ("when: []" is always-true, just like in
python all([]) is true). I'll remove the if_true in v2.
and why not keep the one-liner version?:
stub_ss.add(when: libaio, if_true: files('linux-aio.c'))