[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] qapi: Improve input_type_enum()'s error message
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH] qapi: Improve input_type_enum()'s error message |
|
Date: |
Mon, 11 Oct 2021 15:20:37 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 |
On 10/11/21 15:15, Markus Armbruster wrote:
> The error message claims the parameter is invalid:
>
> $ qemu-system-x86_64 -object qom-type=nonexistent
> qemu-system-x86_64: -object qom-type=nonexistent: Invalid parameter
> 'nonexistent'
>
> What's wrong is actually the *value* 'nonexistent'. Improve the
> message to
>
> qemu-system-x86_64: -object qom-type=nonexistent: Parameter 'qom-type'
> does not accept value 'nonexistent'
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> qapi/qapi-visit-core.c | 3 ++-
> tests/unit/check-qom-proplist.c | 2 +-
> tests/qemu-iotests/049.out | 6 +++---
> tests/qemu-iotests/206.out | 2 +-
> tests/qemu-iotests/237.out | 6 +++---
> tests/qemu-iotests/245 | 2 +-
> 6 files changed, 11 insertions(+), 10 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>