[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 2/2] memory: Update description of memory_region_is_mapped
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH v1 2/2] memory: Update description of memory_region_is_mapped() |
|
Date: |
Tue, 12 Oct 2021 00:17:19 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 |
On 10/11/21 23:21, Richard Henderson wrote:
> On 10/11/21 10:45 AM, David Hildenbrand wrote:
>> /**
>> * memory_region_is_mapped: returns true if #MemoryRegion is mapped
>> - * into any address space.
>> + * into another #MemoryRegion directly. Will return false if the
>> + * #MemoryRegion is mapped indirectly via an alias.
>
> Hmm. I guess. It kinda sorta sounds like a bug, but I don't know the
> interface well enough to tell.
I tend to agree there is a generic issue with aliases, see:
https://www.mail-archive.com/qemu-devel@nongnu.org/msg732527.html
then
https://www.mail-archive.com/qemu-devel@nongnu.org/msg799622.html
"memory: Directly dispatch alias accesses on origin memory region"
The API description looks OK to me, I'd rather change the
implementation... Maybe we need a MR_ALIAS_FOREACH() macro?
- [PATCH v1 0/2] memory: Update description of memory_region_is_mapped(), David Hildenbrand, 2021/10/11
- [PATCH v1 2/2] memory: Update description of memory_region_is_mapped(), David Hildenbrand, 2021/10/11
- Re: [PATCH v1 2/2] memory: Update description of memory_region_is_mapped(), Richard Henderson, 2021/10/11
- Re: [PATCH v1 2/2] memory: Update description of memory_region_is_mapped(),
Philippe Mathieu-Daudé <=
- Re: [PATCH v1 2/2] memory: Update description of memory_region_is_mapped(), David Hildenbrand, 2021/10/12
- Re: [PATCH v1 2/2] memory: Update description of memory_region_is_mapped(), Igor Mammedov, 2021/10/12
- Re: [PATCH v1 2/2] memory: Update description of memory_region_is_mapped(), David Hildenbrand, 2021/10/12
- Re: [PATCH v1 2/2] memory: Update description of memory_region_is_mapped(), Igor Mammedov, 2021/10/12
- Re: [PATCH v1 2/2] memory: Update description of memory_region_is_mapped(), David Hildenbrand, 2021/10/12
- Re: [PATCH v1 2/2] memory: Update description of memory_region_is_mapped(), David Hildenbrand, 2021/10/13
- Re: [PATCH v1 2/2] memory: Update description of memory_region_is_mapped(), Igor Mammedov, 2021/10/13
[PATCH v1 1/2] machine: Use host_memory_backend_is_mapped() in machine_consume_memdev(), David Hildenbrand, 2021/10/11