Re: [PATCH v2 2/5] qapi: Add feature flags to enum members

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 2/5] qapi: Add feature flags to enum members

From:	Kevin Wolf
Subject:	Re: [PATCH v2 2/5] qapi: Add feature flags to enum members
Date:	Tue, 12 Oct 2021 12:41:27 +0200

Am 09.10.2021 um 14:09 hat Markus Armbruster geschrieben:
> This is quite similar to commit 84ab008687 "qapi: Add feature flags to
> struct members", only for enums instead of structs.
> 
> Special feature flag 'deprecated' is silently ignored there.  This is
> okay only because it will be implemented shortly.
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> Reviewed-by: Eric Blake <eblake@redhat.com>

Should we have a test case for an invalid value for 'features'?

Kevin

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH v2 0/5] qapi: Add feature flags to enum members, Markus Armbruster, 2021/10/09
- [PATCH v2 1/5] qapi: Enable enum member introspection to show more than name, Markus Armbruster, 2021/10/09
  - Re: [PATCH v2 1/5] qapi: Enable enum member introspection to show more than name, Eric Blake, 2021/10/11
  - Re: [PATCH v2 1/5] qapi: Enable enum member introspection to show more than name, Kevin Wolf, 2021/10/12
    - Re: [PATCH v2 1/5] qapi: Enable enum member introspection to show more than name, Markus Armbruster, 2021/10/21
- [PATCH v2 3/5] qapi: Move compat policy from QObject to generic visitor, Markus Armbruster, 2021/10/09
- [PATCH v2 4/5] qapi: Implement deprecated-input={reject, crash} for enum values, Markus Armbruster, 2021/10/09
  - Re: [PATCH v2 4/5] qapi: Implement deprecated-input={reject,crash} for enum values, Eric Blake, 2021/10/11
    - Re: [PATCH v2 4/5] qapi: Implement deprecated-input={reject,crash} for enum values, Markus Armbruster, 2021/10/21
- [PATCH v2 2/5] qapi: Add feature flags to enum members, Markus Armbruster, 2021/10/09
  - Re: [PATCH v2 2/5] qapi: Add feature flags to enum members, Kevin Wolf <=
    - Re: [PATCH v2 2/5] qapi: Add feature flags to enum members, Markus Armbruster, 2021/10/21
- [PATCH RFC v2 5/5] block: Deprecate transaction type drive-backup, Markus Armbruster, 2021/10/09
  - Re: [PATCH RFC v2 5/5] block: Deprecate transaction type drive-backup, Eric Blake, 2021/10/11
    - Re: [PATCH RFC v2 5/5] block: Deprecate transaction type drive-backup, Kevin Wolf, 2021/10/12
    - Re: [PATCH RFC v2 5/5] block: Deprecate transaction type drive-backup, Markus Armbruster, 2021/10/21
- Re: [PATCH v2 0/5] qapi: Add feature flags to enum members, Peter Krempa, 2021/10/12

Prev by Date: Re: [PATCH 1/2] numa: Set default distance map if needed
Next by Date: Re: [PATCH v3 01/12] configure, meson: override C compiler for cmake
Previous by thread: [PATCH v2 2/5] qapi: Add feature flags to enum members
Next by thread: Re: [PATCH v2 2/5] qapi: Add feature flags to enum members
Index(es):
- Date
- Thread