qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 13/25] include/sysemu/blockdev.h: move drive_add and inlin


From: Paolo Bonzini
Subject: Re: [PATCH v3 13/25] include/sysemu/blockdev.h: move drive_add and inline drive_def
Date: Tue, 12 Oct 2021 13:06:07 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0

On 12/10/21 10:48, Emanuele Giuseppe Esposito wrote:
+    if (type != IF_DEFAULT) {
+        qemu_opt_set(opts, "if", if_name[type], &error_abort);
+    }

To avoid exporting if_name, this can be replaced by a string argument directly. But in any case this is okay for this series:

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>

Paolo




reply via email to

[Prev in Thread] Current Thread [Next in Thread]