Re: [PATCH v2 13/24] configure, meson: move remaining HAVE_* compiler tests to Meson

[Paolo Bonzini]

On 12/10/21 15:17, Thomas Huth wrote:
> > @@ -1609,7 +1626,8 @@ config_host_data.set('HAVE_BROKEN_SIZE_MAX', not 
> > cc.compiles('''
> >           return printf("%zu", SIZE_MAX);
> >       }''', args: ['-Werror']))
> > -ignored = ['CONFIG_QEMU_INTERP_PREFIX'] # actually per-target
> > +ignored = ['CONFIG_QEMU_INTERP_PREFIX', # actually per-target
> > +    'HAVE_GDB_BIN']
>
> That HAVE_GDB_BIN shows up here a little bit by surprise  ... maybe 
> mention it in the patch description?

It was handled below by the "elif" clause that has been removed.  It 
does not appear in C code so it can be completely ignored; I can make it 
a completely separate patch.

Paolo

> >   arrays = ['CONFIG_BDRV_RW_WHITELIST', 'CONFIG_BDRV_RO_WHITELIST']
> >   strings = ['CONFIG_IASL']
> >   foreach k, v: config_host
> > @@ -1624,7 +1642,7 @@ foreach k, v: config_host
> >       config_host_data.set('HOST_' + v.to_upper(), 1)
> >     elif strings.contains(k)
> >       config_host_data.set_quoted(k, v)
> > -  elif k.startswith('CONFIG_') or k.startswith('HAVE_')
> > +  elif k.startswith('CONFIG_')
> >       config_host_data.set(k, v == 'y' ? 1 : v)
> >     endif
> >   endforeach
>
> Reviewed-by: Thomas Huth <thuth@redhat.com>