Re: [PATCH v2 1/2] hw/core/machine: Split out the smp parsing code

[Andrew Jones]

On Wed, Oct 13, 2021 at 03:41:18PM +0800, Yanan Wang wrote:
> We are going to introduce an unit test for the parser smp_parse()
> in hw/core/machine.c, but now machine.c is only built in softmmu.
> 
> In order to solve the build dependency on the smp parsing code and
> avoid building unrelated stuff for the unit tests, move the tested
> code from machine.c into a separate file, i.e., machine-smp.c and
> build it in common field.
> 
> Signed-off-by: Yanan Wang <wangyanan55@huawei.com>
> ---
>  MAINTAINERS           |   1 +
>  hw/core/machine-smp.c | 181 ++++++++++++++++++++++++++++++++++++++++++
>  hw/core/machine.c     | 159 -------------------------------------
>  hw/core/meson.build   |   2 +
>  include/hw/boards.h   |   1 +
>  5 files changed, 185 insertions(+), 159 deletions(-)
>  create mode 100644 hw/core/machine-smp.c

Reviewed-by: Andrew Jones <drjones@redhat.com>