qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 13/13] iotests: [RFC] drop iotest 297


From: Hanna Reitz
Subject: Re: [PATCH 13/13] iotests: [RFC] drop iotest 297
Date: Wed, 13 Oct 2021 14:23:35 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0

On 04.10.21 23:05, John Snow wrote:
(This is highlighting a what-if, which might make it clear why any
special infrastructure is still required at all. It's not intended to
actually be merged at this step -- running JUST the iotest linters from
e.g. 'make check' is not yet accommodated, so there's no suitable
replacement for 297 for block test authors.)

OK, acknowledged. :)

Hanna

Drop 297. As a consequence, we no longer need to pass an environment
variable to the mypy/pylint invocations, so that can be dropped. We also
now no longer need to hide output-except-on-error, so that can be
dropped as well.

The only thing that necessitates any special running logic anymore is
the skip list and the python-test-detection code. Without those, we
could easily codify the tests as simply:

[pylint|mypy] *.py tests/*.py

... and drop this entire file. We're not quite there yet, though.

Signed-off-by: John Snow <jsnow@redhat.com>
---
  tests/qemu-iotests/297        | 52 -----------------------------------
  tests/qemu-iotests/297.out    |  2 --
  tests/qemu-iotests/linters.py | 20 ++------------
  3 files changed, 2 insertions(+), 72 deletions(-)
  delete mode 100755 tests/qemu-iotests/297
  delete mode 100644 tests/qemu-iotests/297.out




reply via email to

[Prev in Thread] Current Thread [Next in Thread]