qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC PATCH] target/mips: Fix DEXTRV_S.H DSP opcode


From: Richard Henderson
Subject: Re: [RFC PATCH] target/mips: Fix DEXTRV_S.H DSP opcode
Date: Wed, 13 Oct 2021 15:32:21 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0

On 10/13/21 2:56 PM, Philippe Mathieu-Daudé wrote:
While for the DEXTR_S.H opcode:

   "The shift argument is provided in the instruction."

For the DEXTRV_S.H opcode we have:

   "The five least-significant bits of register rs provide the
    shift argument, interpreted as a five-bit unsigned integer;
    the remaining bits in rs are ignored."

While 't1' contains the 'rs' register content (the shift value
for DEXTR_S.H), we need to load the value of 'rs' for DEXTRV_S.H.
We can directly use the v1_t TCG register which already contains
this shift value.

Fixes: b53371ed5d4 ("target-mips: Add ASE DSP accumulator instructions")
Signed-off-by: Philippe Mathieu-Daudé<f4bug@amsat.org>
---
  target/mips/tcg/translate.c | 3 +--
  1 file changed, 1 insertion(+), 2 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]