Re: [PATCH 00/11] 9p: Add support for Darwin

[Greg Kurz]

Hi Will,

It is strongly recommended that you Cc maintainers to increase the odds
they notice your patches in the flood of qemu-devel. FYI I only noticed
them because git-send-email Cc'd me thanks to the Reviewed-by: tags and
my address didn't change in the meantime. I'm thus Cc'ing Christian
who is the primary maintainer now (i.e. the person that can merge
your patches and send a PR for upstream inclusion).

FWIW git-publish [1] can Cc the relevant people for free.

[1] https://github.com/stefanha/git-publish

On Wed, 13 Oct 2021 19:03:54 -0400
Will Cohen <wwcohen@gmail.com> wrote:

> This is a continuation of a patch series adding 9p server support for Darwin,
> originally submitted by Keno Fischer in mid-2018
> (https://lists.nongnu.org/archive/html/qemu-devel/2018-06/msg04643.html). In
> some sense, this could be considered [PATCH v4] of that process, but I assume
> that the multi-year gap merits a fresh start..
> 

This makes sense. For consistency with that assumption, it would also
make sense to clear all preexisting Reviewed-by: tags.

> It has since been updated and rebased for NixOS by Michael Roitzsch
> (https://github.com/NixOS/nixpkgs/pull/122420) with a goal of resubmitting
> upstream. I am submitting his patch set as suggested, as developed by Michael,
> with his Signed-off-by headers included in full.
> 

QEMU cares about tracking of who did what and follows a policy inspired
from the linux kernel [2] [3].

Michael's Signed-off-by: should then appear on all patches, with a
mention of the extra changes that he made, e.g.

Signed-off-by: Keno Fischer <keno@juliacomputing.com>
[Michael Roitzsch: - rebased for NixOS
                   - some other change]
Signed-off-by: Michael Roitzsch <reactorcontrol@icloud.com>

If no changes were made, you still need to add a Signed-off-by: tag.

[2] https://wiki.qemu.org/Contribute/SubmitAPatch
[3] 
http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/SubmittingPatches?id=f6f94e2ab1b33f0082ac22d71f66385a60d8157f#n297

> Additionally, I have run the patches through checkpatch.pl and adjusted coding
> style accordingly (with the exception of ignoring warnings about avoid

Good ! If you have an account on gitlab, you can also push a branch there.
It will be submitted to gitlab CI and maybe give you the opportunity to
polish the patches some more before submission.

> architecture specific defines in hw/9pfs/9p-util-darwin.c, where they seem
> unavoidable), and have signed off on those modified commits.
> 

As explained above, your Signed-off-by: is also needed in all patches,
even if you didn't change them.

Cheers,

--
Greg

> 
>